Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove pytest plugin hook #890

Merged
merged 1 commit into from
Feb 13, 2025
Merged

Remove pytest plugin hook #890

merged 1 commit into from
Feb 13, 2025

Conversation

pholica
Copy link
Contributor

@pholica pholica commented Feb 13, 2025

This broke all (reasonably recent pytest installations) when snactor was not installed.

Resolves: https://issues.redhat.com/browse/RHEL-74372

@github-actions GitHub Actions
Copy link

Thank you for contributing to the Leapp project!

Please note that every PR needs to comply with the Leapp Guidelines and must pass all tests in order to be mergeable.
If you want to request a review or rebuild a package in copr, you can use following commands as a comment:

  • review please @oamg/developers to notify leapp developers of the review request
  • /packit copr-build to submit a public copr build using packit

To launch regression testing public members of oamg organization can leave the following comment:

  • /rerun to schedule basic regression tests using this pr build and leapp-repository*main* as artifacts
  • /rerun 42 to schedule basic regression tests using this pr build and leapp-repository*PR42* as artifacts
  • /rerun-sst to schedule sst tests using this pr build and leapp-repository*main* as artifacts
  • /rerun-sst 42 to schedule sst tests using this pr build and leapp-repository*PR42* as artifacts

Please open ticket in case you experience technical problem with the CI. (RH internal only)

Note: In case there are problems with tests not being triggered automatically on new PR/commit or pending for a long time, please consider rerunning the CI by commenting leapp-ci build (might require several comments). If the problem persists, contact leapp-infra.

@pholica
Remove pytest plugin hook
7f00f6a 
This broke all (reasonably recent pytest installations) when snactor was
not installed. From now on, the tests need to load the plugin explicitly
(either in config or in conftest).

Resolves: https://issues.redhat.com/browse/RHEL-74372
@pirat89 pirat89 added the bug label Feb 13, 2025
@pirat89 pirat89 added this to the 8.10/9.6 milestone Feb 13, 2025
@pirat89
Copy link
Member

pirat89 commented Feb 13, 2025 •
edited
Loading

great! thanks for the contribution! Failed tests are unrelated to the change.

@pirat89 pirat89 merged commit bafd8e2 into main Feb 13, 2025
23 of 28 checks passed
@pirat89 pirat89 deleted the no_pytest_plugin branch February 13, 2025 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pirat89 pirat89 pirat89 approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
8.10/9.6
Development

Successfully merging this pull request may close these issues.
2 participants
@pholica @pirat89