Mark embark-collect variables as private #468
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These definitions have been obsoleted a longer time ago.
These variables are implementation details. Is there a reason to keep them public? I think there is value in cleaning up the public interface, in particular if we apply changes like the live completion/collection removal or candidate marking.
minad
changed the title
This was referenced Mar 3, 2022
Closed
|
I wound up redoing this while working on the embark-collect/embark-live simplification. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without deprecation since I think these variables should have been considered private. I am not aware of any users outside of Embark. Interestingly the embark-collect-* variables are the last variables of Embark which are public besides the customization variables and the keymaps. What do you think?