adding standalone libhdfs3 dir #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this patch allows to use customized libhdfs3 dir Signed-off-by: Yuan Zhou <yuan.zhou@intel.com>
zhouyuan
commented
Apr 26, 2021
| @@ -153,6 +153,7 @@ Result<std::vector<PlatformFilename>> get_potential_libhdfs_paths() { | |||
| ARROW_ASSIGN_OR_RAISE(auto search_paths, MakeFilenameVector({"", "."})); | |||
|
|
|||
| // Path from environment variable | |||
| AppendEnvVarFilename("ARROW_LIBHDFS3_DIR", &search_paths); | |||
There was a problem hiding this comment.
this is a hack-ish solution to support libhdfs3, this would try to add one more call to parse from env variable, needs to check the performance
zhztheplayer
pushed a commit
that referenced
this pull request
May 13, 2021
this patch allows to use customized libhdfs3 dir Signed-off-by: Yuan Zhou <yuan.zhou@intel.com>
zhztheplayer
pushed a commit
that referenced
this pull request
May 13, 2021
this patch allows to use customized libhdfs3 dir Signed-off-by: Yuan Zhou <yuan.zhou@intel.com>
zhztheplayer
pushed a commit
that referenced
this pull request
Feb 28, 2022
this patch allows to use customized libhdfs3 dir Signed-off-by: Yuan Zhou <yuan.zhou@intel.com>
zhztheplayer
pushed a commit
that referenced
this pull request
Mar 15, 2022
this patch allows to use customized libhdfs3 dir Signed-off-by: Yuan Zhou <yuan.zhou@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this patch allows to use customized libhdfs3 dir
Signed-off-by: Yuan Zhou yuan.zhou@intel.com