Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues in multi-key json case and empty value case #54

Merged
merged 1 commit into from
Dec 3, 2021

Conversation

PHILO-HE
Copy link

@PHILO-HE PHILO-HE commented Dec 2, 2021

For multi-key case, get_json_object('$.field_name') should still get correct value. E.g., {"a": 1, "b", 2}, get_json_object('$.b') should return 2. Without this patch, 1 will be incorrectly returned.
For empty value case, e.g., {"a": "", "b", 2}, get_json_object('$.a') should output "" instead of null.

@github-actions
Copy link

github-actions bot commented Dec 2, 2021

Thanks for opening a pull request!

If this is not a minor PR. Could you open an issue for this pull request on JIRA? https://issues.apache.org/jira/browse/ARROW

Opening JIRAs ahead of time contributes to the Openness of the Apache Arrow project.

Then could you also rename pull request title in the following format?

ARROW-${JIRA_ID}: [${COMPONENT}] ${SUMMARY}

or

MINOR: [${COMPONENT}] ${SUMMARY}

See also:

@PHILO-HE
Copy link
Author

PHILO-HE commented Dec 2, 2021

Test result:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants