Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass partition ID to rand expression for achieving genuine random distribution globally #80

Merged
merged 3 commits into from
Jan 26, 2022

Conversation

PHILO-HE
Copy link

@PHILO-HE PHILO-HE commented Jan 25, 2022

In this patch, projection with "rand" is removed from the cache, since "rand(seed)" is stateful. This change need to be discussed.

@github-actions
Copy link

Thanks for opening a pull request!

If this is not a minor PR. Could you open an issue for this pull request on JIRA? https://issues.apache.org/jira/browse/ARROW

Opening JIRAs ahead of time contributes to the Openness of the Apache Arrow project.

Then could you also rename pull request title in the following format?

ARROW-${JIRA_ID}: [${COMPONENT}] ${SUMMARY}

or

MINOR: [${COMPONENT}] ${SUMMARY}

See also:

@zhouyuan zhouyuan merged commit 7a998cd into oap-project:arrow-4.0.0-oap Jan 26, 2022
zhztheplayer pushed a commit that referenced this pull request Feb 28, 2022
…tribution globally (#80)

* Add an offset for seed to achieve genuine random distribution globally

* Filter out rand in projection cache

* Evaluate expr with literal input for getting seed value
zhztheplayer pushed a commit that referenced this pull request Mar 15, 2022
…tribution globally (#80)

* Add an offset for seed to achieve genuine random distribution globally

* Filter out rand in projection cache

* Evaluate expr with literal input for getting seed value
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants