optimize loop

oap-project · Feb 8, 2021 · 24d8b68 · 24d8b68
1 parent fef825f
commit 24d8b68
Showing 1 changed file with 6 additions and 8 deletions.
diff --git a/cpp/src/codegen/arrow_compute/ext/sort_kernel.cc b/cpp/src/codegen/arrow_compute/ext/sort_kernel.cc
@@ -1553,12 +1553,11 @@ class SortOnekeyKernel : public SortArraysToIndicesKernel::Impl {
       auto length = (total_length_ - offset_) > batch_size_ ? batch_size_
                                                             : (total_length_ - offset_);
       uint64_t count = 0;
-      for (int i = 0; i < col_num_; i++) {
-        while (count < length) {
-          auto item = indices_begin_ + offset_ + count++;
+      while (count < length) {
+        auto item = indices_begin_ + offset_ + count++;
+        for (int i = 0; i < col_num_; i++) {
           RETURN_NOT_OK(appender_list_[i]->Append(item->array_id, item->id));
         }
-        count = 0;
       }
       offset_ += length;
       ArrayList arrays;
@@ -1808,12 +1807,11 @@ class SortMultiplekeyKernel  : public SortArraysToIndicesKernel::Impl {
       auto length = (total_length_ - offset_) > batch_size_ ? batch_size_
                                                             : (total_length_ - offset_);
       uint64_t count = 0;
-      for (int i = 0; i < col_num_; i++) {
-        while (count < length) {
-          auto item = indices_begin_ + offset_ + count++;
+      while (count < length) {
+        auto item = indices_begin_ + offset_ + count++;
+        for (int i = 0; i < col_num_; i++) {
           RETURN_NOT_OK(appender_list_[i]->Append(item->array_id, item->id));
         }
-        count = 0;
       }
       offset_ += length;
       ArrayList arrays;