Skip to content
This repository has been archived by the owner on Sep 18, 2023. It is now read-only.

[NSE-1166] Cover peers' values in sum window function in range mode #1167

Merged
merged 7 commits into from
Nov 9, 2022
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove a comment
PHILO-HE committed Nov 8, 2022
commit d10c2b4b285eba3c32e382047bf9307b89c614f3
Original file line number Diff line number Diff line change
@@ -1006,8 +1006,7 @@ arrow::Status WindowSumKernel::HandleSortedPartition(
std::dynamic_pointer_cast<ArrayType>(values.at(index->array_id).at(column_id));
// If the first value in one partition (ordered) is null, the result is null.
// If there is valid value before null, the result for null is as same as the
// above. So for same value in ordered col, the sum result may be different from
// vanilla's.
// above.
if (typed_array->null_count() > 0 && typed_array->IsNull(index->id)) {
if (!is_valid_value_found) {
validity[index->array_id][index->id] = false;