Skip to content
This repository has been archived by the owner on Sep 18, 2023. It is now read-only.

[NSE-248] fix arrow dependency order #259

Merged
merged 3 commits into from
Apr 19, 2021

Conversation

weiting-chen
Copy link
Collaborator

What changes were proposed in this pull request?

Close #248
Move script to arrow-data-source's parent, let arrow can be installed before arrow dataset dependency check.

How was this patch tested?

Locally Tested

@weiting-chen weiting-chen requested a review from zhouyuan April 18, 2021 15:19
@github-actions
Copy link

Thanks for opening a pull request!

Could you open an issue for this pull request on Github Issues?

https://github.com/oap-project/native-sql-engine/issues

Then could you also rename commit message and pull request title in the following format?

[NSE-${ISSUES_ID}] ${detailed message}

See also:

@zhouyuan zhouyuan changed the title Wip install order v3 [NSE-248] fix arrow dependency order Apr 19, 2021
@github-actions
Copy link

#248

Copy link
Collaborator

@zhouyuan zhouyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good if the CI is green

@weiting-chen weiting-chen force-pushed the wip_install_order_v3 branch from 69142c4 to 6fe3437 Compare April 19, 2021 02:01
@weiting-chen weiting-chen merged commit 55b13eb into oap-project:master Apr 19, 2021
zhouyuan pushed a commit to zhouyuan/native-sql-engine that referenced this pull request Apr 19, 2021
* Only read .so.300.0.0

* Fix arroow dataset dependency issue

* Add ARROW_S3=ON, Add symlink copy in CMakeList.
zhouyuan added a commit that referenced this pull request Apr 19, 2021
* [NSE-229] Fix the deprecated code warning in shuffle_split_test (#230)

* fix the deprecated code warning in shuffle_split_test

* fix the code style

* format update

* [NSE-239] Adopt ARROW-7011 (#240)

* [NSE-224] update third party code (#242)

* update third party code

Signed-off-by: Yuan Zhou <yuan.zhou@intel.com>

* fix format

Signed-off-by: Yuan Zhou <yuan.zhou@intel.com>

* [NSE-176]Arrow install order issue (#231)

* Add Arrow install script

* [NSE-176]Add Arrow install Script in Arrow Data Source

* remove popd parameter for ubuntu

* Change variables to BFS

* Update Arrow Header and Find Arrow function

* Fix one issue with reading wrong Arrow Path

* Update ARROW_CSV=ON

* Update build_arrow=OFF in Scala UT

* Install parent pom file in Scala UT

* [NSE-196] clean up native sql options (#215)

* clean up native sql options

Signed-off-by: Yuan Zhou <yuan.zhou@intel.com>

* adding more options

Signed-off-by: Yuan Zhou <yuan.zhou@intel.com>

* adding more options

Signed-off-by: Yuan Zhou <yuan.zhou@intel.com>

* adding warning log for running on non-intel cpu

Signed-off-by: Yuan Zhou <yuan.zhou@intel.com>

* [NSE-206]doc update on feature support status (#253)

* update operators support status

Signed-off-by: Yuan Zhou <yuan.zhou@intel.com>

* update docs on operators supporting status

Signed-off-by: Yuan Zhou <yuan.zhou@intel.com>

* fix

Signed-off-by: Yuan Zhou <yuan.zhou@intel.com>

* [NSE-241] fix hashagg result length (#249)

* fix hashagg result length

Signed-off-by: Yuan Zhou <yuan.zhou@intel.com>

* optimize on getting batch size

Signed-off-by: Yuan Zhou <yuan.zhou@intel.com>

* using fixed sized output len for hashagg

Signed-off-by: Yuan Zhou <yuan.zhou@intel.com>

* fix format

Signed-off-by: Yuan Zhou <yuan.zhou@intel.com>

* [NSE-248] fix arrow dependency order (#259)

* Only read .so.300.0.0

* Fix arroow dataset dependency issue

* Add ARROW_S3=ON, Add symlink copy in CMakeList.

Co-authored-by: JiaKe <ke.a.jia@intel.com>
Co-authored-by: Hongze Zhang <hongze.zhang@intel.com>
Co-authored-by: Wei-Ting Chen <weiting.chen@intel.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

arrow dependency must put after arrow installation
2 participants