This repository has been archived by the owner on Sep 18, 2023. It is now read-only.
[NSE-400] Optimize ColumnarToRow Operator in NSE. #401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@JkSelf clang-10 is used to check format currently |
zhouyuan
reviewed
Jul 15, 2021
| return out; | ||
| } | ||
|
|
||
| arrow::Status WriteValue(std::shared_ptr<arrow::ResizableBuffer> buffer, int64_t offset, |
There was a problem hiding this comment.
template this func can help to reduce the long switch/case?
zhouyuan
reviewed
Jul 19, 2021
| @@ -71,6 +71,9 @@ class ColumnarPluginConfig(conf: SQLConf) extends Logging { | |||
| val enableColumnarShuffledHashJoin: Boolean = | |||
| conf.getConfString("spark.oap.sql.columnar.shuffledhashjoin", "true").toBoolean && enableCpu | |||
|
|
|||
| val enableArrowColumnarToRow: Boolean = | |||
| conf.getConfString("spark.oap.sql.columnar.columnartorow", "true").toBoolean && enableCpu | |||
There was a problem hiding this comment.
how about this make this to false and improve the performance later?
…endarIntervalType
fix value count
|
@JkSelf can you take a look at the unit tests script? |
zhouyuan
approved these changes
Jul 21, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR replace the ColumnarToRow operator with the ArrowColumnarToRow operator, which convert the RDD[ColumnBatch] to Arrow RecordBatch and then convert the Arrow Record Batch to Spark UnsafeRow.
How was this patch tested?
UT added
locally verified on TPC-DS