This repository has been archived by the owner on Sep 18, 2023. It is now read-only.
[NSE-475] restore coalescebatches operator before window #486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yuan Zhou <yuan.zhou@intel.com>
zhouyuan
commented
Aug 19, 2021
| @@ -504,7 +504,7 @@ object ColumnarWindowExec extends Logging { | |||
| object ColumnarWindowOptimizations extends RuleExecutor[SparkPlan] { | |||
| override protected def batches: Seq[ColumnarWindowOptimizations.Batch] = | |||
| Batch("Remove Sort", FixedPoint(10), RemoveSort) :: | |||
| Batch("Remove Coalesce Batches", FixedPoint(10), RemoveCoalesceBatches) :: | |||
| // Batch("Remove Coalesce Batches", FixedPoint(10), RemoveCoalesceBatches) :: | |||
| // Batch("Cast Mutable Types", Once, CastMutableTypes) :: | |||
There was a problem hiding this comment.
will remove the dead code if CI is green
Signed-off-by: Yuan Zhou <yuan.zhou@intel.com>
zhouyuan
added a commit
to zhouyuan/native-sql-engine
that referenced
this pull request
Aug 20, 2021
…#486) * restore coalescebatches operator before window Signed-off-by: Yuan Zhou <yuan.zhou@intel.com> * remove dead code Signed-off-by: Yuan Zhou <yuan.zhou@intel.com>
zhouyuan
added a commit
that referenced
this pull request
Aug 20, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This patch restore the coalescebatches before window so the "empty partitions" were removed
Signed-off-by: Yuan Zhou yuan.zhou@intel.com
How was this patch tested?
locally verified