This repository has been archived by the owner on Sep 18, 2023. It is now read-only.
[NSE-53]Partial fix Q24a/Q24b tail SHJ task materialization performance issue #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chendi Xue <chendi.xue@intel.com>
|
|
|
|
|
|
Signed-off-by: Chendi Xue <chendi.xue@intel.com>
xuechendi
force-pushed
the
wip_q24a_opt
branch
from
4876d02 to
fc5cb33
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed: #53
This Issue is due to some join task in 24a/24b will expand input table 1000 times, which leads to output result contains 100 million + numRows, so the materialization is extremely slow
in this PR, we tried to accelerate materialization
TODO:
If we can merge this Join with following Aggregate in a whole stage code gen, this issue may be fully fixed.