This repository has been archived by the owner on Sep 18, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 75
[NSE-561] refine docs on sample configurations and code generation behavior #572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yuan Zhou <yuan.zhou@intel.com>
Signed-off-by: Yuan Zhou <yuan.zhou@intel.com>
Signed-off-by: Yuan Zhou <yuan.zhou@intel.com>
weiting-chen
approved these changes
Nov 18, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Signed-off-by: Yuan Zhou <yuan.zhou@intel.com>
Signed-off-by: Yuan Zhou <yuan.zhou@intel.com>
@HongW2019 can you please also take a look on this change? |
HongW2019
reviewed
Nov 18, 2021
zhouyuan
commented
Nov 18, 2021
rui-mo
pushed a commit
to rui-mo/native-sql-engine
that referenced
this pull request
Nov 26, 2021
…havior (oap-project#572) * refine doc Signed-off-by: Yuan Zhou <yuan.zhou@intel.com> * refine Signed-off-by: Yuan Zhou <yuan.zhou@intel.com> * adding perf tuning Signed-off-by: Yuan Zhou <yuan.zhou@intel.com> * fix index page Signed-off-by: Yuan Zhou <yuan.zhou@intel.com> * update doc Signed-off-by: Yuan Zhou <yuan.zhou@intel.com> * remove duplicate page Signed-off-by: Yuan Zhou <yuan.zhou@intel.com> * fix link Signed-off-by: Yuan Zhou <yuan.zhou@intel.com>
weiting-chen
added
bug
Something isn't working
documentation
Improvements or additions to documentation
labels
Apr 8, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This patch refines the doc on example configurations and codegen behavior in driver
closes: #561
How was this patch tested?
no tests required