This repository has been archived by the owner on Sep 18, 2023. It is now read-only.
[NSE-576] Support from_unixtime expression in the case that 'yyyyMMdd' format is required #614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues? https://github.com/oap-project/native-sql-engine/issues Then could you also rename commit message and pull request title in the following format? See also: |
zhouyuan
reviewed
Dec 12, 2021
| @@ -62,7 +62,7 @@ echo "ARROW_SOURCE_DIR=${ARROW_SOURCE_DIR}" | |||
| echo "ARROW_INSTALL_DIR=${ARROW_INSTALL_DIR}" | |||
| mkdir -p $ARROW_SOURCE_DIR | |||
| mkdir -p $ARROW_INSTALL_DIR | |||
| git clone https://github.com/oap-project/arrow.git --branch arrow-4.0.0-oap $ARROW_SOURCE_DIR | |||
| git clone https://github.com/philo-he/arrow.git --branch from_unixtime $ARROW_SOURCE_DIR | |||
There was a problem hiding this comment.
can you remove this change?
|
The temp changes for arrow branch was just removed. Also rebased the code. |
zhouyuan
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch depends on oap-project/arrow#56.