This repository has been archived by the owner on Sep 18, 2023. It is now read-only.
[NSE-636]Update log4j to 2.15.0 #634
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues? https://github.com/oap-project/native-sql-engine/issues Then could you also rename commit message and pull request title in the following format? See also: |
zhouyuan
reviewed
Dec 15, 2021
| <dependency> | ||
| <groupId>org.apache.logging.log4j</groupId> | ||
| <artifactId>log4j-core</artifactId> | ||
| <version>2.15.0</version> |
There was a problem hiding this comment.
bump to 2.16.0?
we may only need log4j-core?
There was a problem hiding this comment.
can you update log4j version to 2.16.0
There was a problem hiding this comment.
After our testing, the PR will be postponed until Spark update log4j to 2.16.0 or later since there are lots of unit test still need Spark's log4j dependency, we cannot fix those dependencies by ourselves.
|
@weiting-chen Regarding data source module, it looks even weird that slf4j/log4j dependencies were not excluded by Following is the dependency tree of module The issue is similar to https://issues.apache.org/jira/browse/MNG-6607 |
|
@zhztheplayer |
|
We decide to remove the direct usage for log4j and keep the usage for log4j in spark-core for testing unit test. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
(Please fill in changes proposed in this fix)
How was this patch tested?
(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)
(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)