Skip to content
This repository has been archived by the owner on Sep 18, 2023. It is now read-only.

[NSE-635] Add document to clarify incompatibility issues in expressions #657

Merged
merged 5 commits into from
Jan 12, 2022

Conversation

PHILO-HE
Copy link
Collaborator

WIP PR.

@PHILO-HE PHILO-HE self-assigned this Dec 23, 2021
@github-actions
Copy link

#635

@PHILO-HE PHILO-HE marked this pull request as draft December 23, 2021 09:51
@PHILO-HE PHILO-HE force-pushed the compatibility branch 2 times, most recently from 6c7911c to 953fa21 Compare January 6, 2022 05:56
| 3 | date/time related expressions | Incompatibility issues for different LEGACY_TIME_PARSER_POLICY <br/>(corrected, exception, legacy). |
| 4 | expressions with date format provided. | Parsing user-specified date format is not well supported. |
| 5 | castINT/castBIGINT/castFLOAT4/castFLOAT8| Return digital part leading in strings like "123abc" in WSCG, but vanilla spark return null. |
| 6 | all expressions | Incompatibility issue when ANSI is on (throw exceptions at runtime instead of return null). |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe it's better to call out this ANSI issue in the first line

@zhouyuan zhouyuan marked this pull request as ready for review January 12, 2022 07:17
@zhouyuan zhouyuan merged commit a86d2e0 into oap-project:master Jan 12, 2022
zhouyuan pushed a commit that referenced this pull request Jan 12, 2022
…ns (#657)

* Initial commit

* Clarify incompatibility cases in casting string to int/bigint/float4/float8

* Update the table

* Rename the doc

* Update the doc
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants