This repository has been archived by the owner on Sep 18, 2023. It is now read-only.
[NSE-68][Shuffle] Adaptive compression select in Shuffle. #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JkSelf
force-pushed
the
updateCompressType
branch
from
13d55a3 to
6161dd7
Compare
|
|
JkSelf
force-pushed
the
updateCompressType
branch
from
6161dd7 to
fed77f9
Compare
|
@zhouyuan Already add the data type check in java side. Please help me review. Thanks. |
|
@JkSelf can you please do a rebase? there's a small conflict with recent commits |
zhouyuan
reviewed
Feb 4, 2021
| val columnarShuffleUseCustomizedCompression: Boolean = | ||
| conf.getBoolean("spark.oap.sql.columnar.shuffle.customizedCompression", defaultValue = false) | ||
| val columnarShuffleUseCustomizedCompressionCodec: String = | ||
| conf.get("spark.oap.sql.columnar.shuffle.customizedCompression.codec", defaultValue = "lz4") |
There was a problem hiding this comment.
can you please make a note here on the available codec?
JkSelf
force-pushed
the
updateCompressType
branch
from
fed77f9 to
ea31bc7
Compare
|
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This pr is to support adaptive compression select in Shuffle.
Fix PR#68
How was this patch tested?
Existing unit test and TPCH benchmark locally
(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)