This repository has been archived by the owner on Sep 18, 2023. It is now read-only.
[NSE-705] Fallback R2C on unsupported cases #706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@PHILO-HE please take a review on this pr, thanks. |
zhouyuan
reviewed
Jan 18, 2022
| @@ -65,7 +65,7 @@ class ArrowRowToColumnarExec(child: SparkPlan) extends RowToColumnarExec(child = | |||
| case d: BinaryType => | |||
| case _ => | |||
| throw new UnsupportedOperationException(s"${field.dataType} " + | |||
| s"is not supported in ArrowColumnarToRowExec.") | |||
| s"is not supported in ArrowRowToColumnarExec.") | |||
There was a problem hiding this comment.
@haojinIntel based on what i learned, r2c should support array type already?
haojinIntel
reviewed
Jan 18, 2022
| @@ -65,7 +65,7 @@ class ArrowRowToColumnarExec(child: SparkPlan) extends RowToColumnarExec(child = | |||
| case d: BinaryType => | |||
There was a problem hiding this comment.
We've supported ArrayType (not supported nested type) for ArrowRowToColumnarExec but not add it on "buildCheck". We can pass the unit tests by adding the code like following picture:
rui-mo
commented
Jan 18, 2022
| } catch { | ||
| case _: Throwable => | ||
| logInfo("ArrowRowToColumnar: Falling back to RowToColumnar...") | ||
| RowToArrowColumnarExec(child) |
There was a problem hiding this comment.
@haojinIntel hi, I added ArrayType to buildCheck. But the fallback logics may be still needed to prevent throwing exception on other unsupported cases. Please take a review for that, thanks.
zhouyuan
approved these changes
Jan 18, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This pr added the fallback logic for R2C.
Fixed #705.
How was this patch tested?
locally verified