Skip to content
This repository has been archived by the owner on Sep 18, 2023. It is now read-only.

[NSE-70] remove duplicate IsNull check in sort #71

Merged
merged 1 commit into from
Feb 1, 2021
Merged

[NSE-70] remove duplicate IsNull check in sort #71

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions cpp/src/codegen/arrow_compute/ext/sort_kernel.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -516,9 +516,7 @@ extern "C" void MakeCodeGen(arrow::compute::FunctionContext* ctx,
// Multiple keys sorting w/ nulls first/last is supported.
std::stringstream ss;
// We need to determine the position of nulls.
ss << "if (" << is_x_null << " && " << is_y_null << ") {\n";
ss << "return false;} "
<< "else if (" << is_x_null << ") {\n";
ss << "if (" << is_x_null << ") {\n";
// If value accessed from x is null, return true to make nulls first.
if (nulls_first) {
ss << "return true;\n}";
Expand All @@ -535,9 +533,7 @@ extern "C" void MakeCodeGen(arrow::compute::FunctionContext* ctx,
// If datatype is floating, we need to do partition for NaN if NaN check is enabled
if (data_type->id() == arrow::Type::DOUBLE || data_type->id() == arrow::Type::FLOAT) {
if (NaN_check_) {
ss << " else if (" << is_x_nan << " && " << is_y_nan << ") {\n";
ss << "return false;} "
<< "else if (" << is_x_nan << ") {\n";
ss << "else if (" << is_x_nan << ") {\n";
if (asc) {
ss << "return false;\n}";
} else {
Expand Down