This repository has been archived by the owner on Sep 18, 2023. It is now read-only.
[NSE-791] fix xchg reuse in Spark321 #799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yuan Zhou <yuan.zhou@intel.com>
Signed-off-by: Yuan Zhou <yuan.zhou@intel.com>
zhouyuan
changed the title
zhouyuan
commented
Mar 25, 2022
| @@ -389,7 +389,8 @@ case class ColumnarPostOverrides() extends Rule[SparkPlan] { | |||
| s" See above override in BroadcastQueryStageExec") | |||
| val localBroadcastXchg = broadcastQueryStageExec.plan.asInstanceOf[BroadcastExchangeExec] | |||
| val dataToArrowColumnar = localBroadcastXchg.child.asInstanceOf[DataToArrowColumnarExec] | |||
| ColumnarBroadcastExchangeExec(localBroadcastXchg.mode, dataToArrowColumnar) | |||
| //ColumnarBroadcastExchangeExec(localBroadcastXchg.mode, dataToArrowColumnar) | |||
There was a problem hiding this comment.
This removed unnecessary DataToArrowColumnar and ColumnarBroadcastExchange
zhouyuan
commented
Mar 25, 2022
| // and reuse the existing stage found in the `stageCache`, otherwise update the | ||
| // `stageCache` with the new stage. | ||
| val queryStage = context.stageCache.getOrElseUpdate( | ||
| e.canonicalized, newStage) |
There was a problem hiding this comment.
partially revert Spark change on exchange key
zhouyuan
added a commit
to zhouyuan/native-sql-engine
that referenced
this pull request
Mar 28, 2022
* fix xchg reuse Signed-off-by: Yuan Zhou <yuan.zhou@intel.com> * move to spark321 shim layer Signed-off-by: Yuan Zhou <yuan.zhou@intel.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This patch fixed the xchg reuse in Spark 321.
Signed-off-by: Yuan Zhou yuan.zhou@intel.com
How was this patch tested?
pass jenkins