Skip to content
This repository has been archived by the owner on Sep 18, 2023. It is now read-only.

[NSE-912] Remove extra handleSafe costs #922

Merged
merged 2 commits into from
May 25, 2022

Conversation

jackylee-ch
Copy link
Contributor

What changes were proposed in this pull request?

We are using setSafe to put partitionValues to Vectors while calling buildReaderWithPartitionValues. As showing in bellow image, it cost 11% cpu time to check handleSafe.
image
Actually, the partitionValues written are all fixed length, so we can handleSafe once before writing into arrow, and use Vector.set instead of Vector.setSafe to remove extra handleSafe costs.

How was this patch tested?

Unit tests

@github-actions
Copy link

#912

@zhouyuan zhouyuan merged commit d263ec5 into oap-project:main May 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants