[NSE-926] Support a UDF: URLDecoder #925
Conversation
|
Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues? https://github.com/oap-project/native-sql-engine/issues Then could you also rename commit message and pull request title in the following format? See also: |
|
This functionality depends on the row based UDF registering. Thus, the corresponding columnar expression can replace it. The jar contains the row based UDF implementation need be put in spark classpath. This is an example: |
|
This PR depends on oap-project/arrow#105. |
PHILO-HE
changed the title
|
Jenkins UT and TPC-DS tests passed. |
| def create(children: Seq[Expression], original: Expression): Expression = { | ||
| original.prettyName match { | ||
| // Hive UDF. | ||
| case "UrlDecoder" => |
There was a problem hiding this comment.
does this mean the UDF name is case sensitive? e.g., urlDecoder and UrlDecoder are different UDF
There was a problem hiding this comment.
Just ignore case in the latest commit which has been validated by some simple tests.
|
note: the docs on UDF will be added in another PR |
What changes were proposed in this pull request?
Support a UDF: URLDecoder.
How was this patch tested?
UT in native code & scala code.