[ML-186]Support CDH spark versions #199
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: minmingzhu <minming.zhu@intel.com>
xwu99
requested changes
Apr 1, 2022
| @@ -31,7 +31,16 @@ trait NaiveBayesShim extends Logging { | |||
| object NaiveBayesShim extends Logging { | |||
| def create(uid: String): NaiveBayesShim = { | |||
| logInfo(s"Loading NaiveBayes for Spark $SPARK_VERSION") | |||
| val shim = SPARK_VERSION match { | |||
| // For example: CHD spark version was 3.1.1.3.1.7290.5-2. | |||
There was a problem hiding this comment.
Suggested change
| // For example: CHD spark version was 3.1.1.3.1.7290.5-2. | |
| // For example: CDH spark version is 3.1.1.3.1.7290.5-2. |
| @@ -31,7 +31,16 @@ trait NaiveBayesShim extends Logging { | |||
| object NaiveBayesShim extends Logging { | |||
| def create(uid: String): NaiveBayesShim = { | |||
| logInfo(s"Loading NaiveBayes for Spark $SPARK_VERSION") | |||
| val shim = SPARK_VERSION match { | |||
| // For example: CHD spark version was 3.1.1.3.1.7290.5-2. | |||
| // Intercepting the third decimal point is the spark version. | |||
There was a problem hiding this comment.
Suggested change
| // Intercepting the third decimal point is the spark version. | |
| // The string before the third dot is the spark version. |
|
You just added CDH support for Naive Bayes only, other algorithms are needed as well. |
|
Use #197 instead |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: minmingzhu minming.zhu@intel.com
What changes were proposed in this pull request?
closes #186
Does this PR also require the following changes?
No.