Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML-202] Update oneAPI Base Toolkit version and prepare for OAP 1.3.1 release #203

Merged
merged 10 commits into from
Apr 8, 2022

Conversation

HongW2019
Copy link
Contributor

What changes were proposed in this pull request?

Update oneAPI Base Toolkit version to mitigate vulnerabilities scanned from libmpi and prepare for OAP 1.3.1 release

Does this PR also require the following changes?

  • CI
  • Documentation
  • Example

@github-actions
Copy link

github-actions bot commented Apr 2, 2022

#202

@HongW2019
Copy link
Contributor Author

@xwu99 Please take a review, thanks.

@xwu99
Copy link
Collaborator

xwu99 commented Apr 6, 2022

@xwu99 Please take a review, thanks.

Thanks for your work!
Checked CI, dev/prepare-build-deps.sh should also be fixed.
Should also change the version in main README.

@xwu99 xwu99 mentioned this pull request Apr 6, 2022
@xwu99
Copy link
Collaborator

xwu99 commented Apr 7, 2022

@HongW2019 I adjust compiler setting to use gcc for cpu profile and dpcpp for cpu_gpu profile. The old setting of using dpcpp will bring gpu dependencies even for cpu only package.

.github/workflows/ci-checks-build.yml Outdated Show resolved Hide resolved
@HongW2019
Copy link
Contributor Author

@HongW2019 I adjust compiler setting to use gcc for cpu profile and dpcpp for cpu_gpu profile. The old setting of using dpcpp will bring gpu dependencies even for cpu only package.

Great! thanks for your help.

@HongW2019
Copy link
Contributor Author

@xwu99 If there is no more action needed for this PR, could you please help merge it? and also help backport those commits that mllib-1.3.1 needs to branch-1.3.1? Thanks a lot.

@xwu99
Copy link
Collaborator

xwu99 commented Apr 7, 2022

@xwu99 If there is no more action needed for this PR, could you please help merge it? and also help backport those commits that mllib-1.3.1 needs to branch-1.3.1? Thanks a lot.

Did you scan the package to see if it fixed the issue #202 ? For 1.3.1, just need to merge all commits since the cutoff. I can do it after this PR merged.

@HongW2019
Copy link
Contributor Author

@xwu99 If there is no more action needed for this PR, could you please help merge it? and also help backport those commits that mllib-1.3.1 needs to branch-1.3.1? Thanks a lot.

Did you scan the package to see if it fixed the issue #202 ? For 1.3.1, just need to merge all commits since the cutoff. I can do it after this PR merged.

I have locally tested this PR before 11960fd7b07 committed, it can solve the the json-c vulnerability brought from libmpi.

Now to build oap-mllib with the whole patch locally, the package can also avoid the the json-c vulnerability brought from libmpi. I also found that building env had limit to gcc version after 11960fd7b07 committed. In my previous build env, gcc 7.3 worked good on CentOS 7, but didn't work for current whole PR to build. I tried gcc 9 then oap-mllib was built successfully.

@xwu99
Copy link
Collaborator

xwu99 commented Apr 7, 2022

Previously the compiler is clang from oneapi package. it doesn't use system gcc.
What is your build issue right now? My env is gcc 7 in ubuntu 18.04. It worked perfectly for this patch.
You can also check CI "OAP MLlib Checks and Build". It's exactly the same with my local result.

@HongW2019
Copy link
Contributor Author

Previously the compiler is clang from oneapi package. it doesn't use system gcc. What is your build issue right now? My env is gcc 7 in ubuntu 18.04. It worked perfectly for this patch. You can also check CI "OAP MLlib Checks and Build". It's exactly the same with my local result.

You are right, gcc 7 works well to build oap-mllib. I use another clean machine with gcc 7 to build and it works, so previously what I mentioned isn't an issue.

@xwu99 xwu99 merged commit 8f3ab75 into oap-project:master Apr 8, 2022
@xwu99
Copy link
Collaborator

xwu99 commented Apr 8, 2022

@HongW2019 Thanks for your work! merged for master and 1.3.1 branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants