-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ML-202] Update oneAPI Base Toolkit version and prepare for OAP 1.3.1 release #203
Conversation
@xwu99 Please take a review, thanks. |
Thanks for your work! |
@HongW2019 I adjust compiler setting to use gcc for cpu profile and dpcpp for cpu_gpu profile. The old setting of using dpcpp will bring gpu dependencies even for cpu only package. |
Great! thanks for your help. |
@xwu99 If there is no more action needed for this PR, could you please help merge it? and also help backport those commits that mllib-1.3.1 needs to branch-1.3.1? Thanks a lot. |
Did you scan the package to see if it fixed the issue #202 ? For 1.3.1, just need to merge all commits since the cutoff. I can do it after this PR merged. |
I have locally tested this PR before Now to build oap-mllib with the whole patch locally, the package can also avoid the the json-c vulnerability brought from libmpi. I also found that building env had limit to gcc version after |
Previously the compiler is clang from oneapi package. it doesn't use system gcc. |
You are right, gcc 7 works well to build oap-mllib. I use another clean machine with gcc 7 to build and it works, so previously what I mentioned isn't an issue. |
@HongW2019 Thanks for your work! merged for master and 1.3.1 branch |
What changes were proposed in this pull request?
Update oneAPI Base Toolkit version to mitigate vulnerabilities scanned from libmpi and prepare for OAP 1.3.1 release
Does this PR also require the following changes?