[ML-362] Create new Homogen Table with assign GPU before algorithms running. #366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: minmingzhu <minming.zhu@intel.com>
xwu99
requested changes
Oct 24, 2023
| preview::spmd::communicator<preview::spmd::device_memory_access::usm> comm, | ||
| jobject resultObj) { | ||
| jobject resultObj, sycl::queue &queue) { |
There was a problem hiding this comment.
could you make queue a private member of comm, so that can be got from comm without change the interface?
There was a problem hiding this comment.
the interfaces is still changed, could you remove queue in the interface?
xwu99
reviewed
Nov 2, 2023
xwu99
reviewed
Nov 2, 2023
xwu99
reviewed
Jul 22, 2024
Signed-off-by: minmingzhu <minming.zhu@intel.com>
Signed-off-by: minmingzhu <minming.zhu@intel.com>
Signed-off-by: minmingzhu <minming.zhu@intel.com>
Signed-off-by: minmingzhu <minming.zhu@intel.com>
Signed-off-by: minmingzhu <minming.zhu@intel.com>
minmingzhu
force-pushed
the
assign_gpu_to_homogentable
branch
from
f2b5ed0 to
157fe7d
Compare
xwu99
approved these changes
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
closes #362