[ML-26] Build for different spark version by -Pprofile #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues? Then could you also rename pull request title and commit log in the following format? See also: |
bobjiang82
changed the title
xwu99
requested changes
Mar 26, 2021
xwu99
reviewed
Mar 31, 2021
|
@xwu99 , any further comments on this? |
|
@bobjiang82 , can we also add support for 3.0.1? OAP will probably have a minor release for 3.0.1 so all components will need to support it. |
|
@bobjiang82 Could you merge changes from master as I have some updates in #44. And could you pls also add 3.0.1 support as Carson mentioned. I also have added unit test and cluster test in CI. You need to check all profiles passed CI. |
reorganize folders for build by profile update KMeans DAL for profile spark-3.0.2 update KMeans DAL for profile spark-3.1.1; update PCA DAL for spark-3.0.2 and spark-3.1.1. Update oap-mllib-ci.yml Add tests for building by profile Update pom.xml remove duplicated <spark.version>3.0.0</spark.version> as it is set in the default activated profile updated README.md
|
Rebased and added spark v3.0.1 support. |
bobjiang82
force-pushed
the
buildbyprofile
branch
from
a05ff4f to
c1516ad
Compare
xwu99
requested changes
Apr 28, 2021
xwu99
requested changes
Apr 29, 2021
xwu99
reviewed
Apr 29, 2021
|
@bobjiang82 Merged! Thanks for your work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
For supporting different Spark versions.
(Please fill in changes proposed in this fix)