This repository has been archived by the owner on Sep 18, 2023. It is now read-only.
[PMEM-SHUFFLE-7] enable fsdax mode in pmem-shuffle #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. delete the fsdax file with POSIX API 2. delete fsdax files independently 3. fix fsdax mode in NUMA binding
enable fsdax mode in native:add param size in create method. When using devdax, the size is changed to 0 in the upper level code
|
Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues? https://github.com/oap-project/pmem-shuffle/issues Then could you also rename commit message and pull request title in the following format? See also: |
Eugene-Mark
suggested changes
Mar 4, 2021
add size param in native code.
Eugene-Mark
approved these changes
Mar 4, 2021
|
It's related to issue #7 |
kelvin-qin
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now Spark pmem-shuffle doesn't work in pmem's FSDAX mode.
This should be optional, and users should have the option to run on FSDAX when they are not using RDMA NIC(RDMA is too complex to use).
Therefore, it is necessary to make appropriate modifications to the code to run in FSDAX mode.
1.Create the poolfile of fsdax and specify the size in Scala (this is different from devdax)
2.When creating a pool, identify whether the device type is fsdax or devdax, and add judgment conditions to NATIVE code.
3.Other potential risks,eg. NUMA binding.