This repository has been archived by the owner on Nov 14, 2022. It is now read-only.
[POAE7-858] disable RDD cache related PMem intialization as default and add PMem related logic in SparkEnv #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
winningsix
reviewed
Mar 3, 2021
| @@ -0,0 +1,509 @@ | |||
| /* | |||
There was a problem hiding this comment.
As per discussed, let's divide this into two steps: 1. commit Spark files as it is; 2. update our changes. This can reduce a little bit maintenance effort from version to version.
There was a problem hiding this comment.
Separate PR submitted. Let's merge this one after that one merged.
| @@ -35,7 +35,7 @@ public PMemReaderForUnsafeExternalSorter( | |||
| this.numRecordsRemaining = numRecords - position/2; | |||
| this.taskMetrics = taskMetrics; | |||
| int readBufferSize = SparkEnv.get() == null? 8 * 1024 * 1024 : | |||
| (int) SparkEnv.get().conf().get(package$.MODULE$.MEMORY_SPILL_PMEM_READ_BUFFERSIZE()); | |||
| (int) (long) SparkEnv.get().conf().get(package$.MODULE$.MEMORY_SPILL_PMEM_READ_BUFFERSIZE()); | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
This code is referring other similar usages in Vanilla Spark.
There was a problem hiding this comment.
Interesting, didn't think up why they didn't use a getLong API? That seems better.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
disable RDD cache related PMem intialization as default and add PMem related logic in SparkEnv
How was this patch tested?
Q64 tested