Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix executor custom resource request+support pyarrow >=15 & spark 3.5.2/3/4 #419

Merged
merged 11 commits into from
Dec 26, 2024

Conversation

pang-wu
Copy link
Contributor

@pang-wu pang-wu commented Dec 8, 2024

This PR does the following:

  • Deprecate MLDataset, so the library can work on pyarrow >= 15.0.0
  • Fix a bug in parsing custom resource for executor actor
  • Support Spark 3.5.2 and 3.5.3
  • Support Ray 2.39+

@pang-wu pang-wu changed the title fix executor custom resource request+support spark 3.5.2/3 fix executor custom resource request+support pyarrow >=15 & spark 3.5.2/3 Dec 8, 2024
@carsonwang
Copy link
Collaborator

@pang-wu, thanks for the PR. This looks good! Can you please check how to pass all the CI tests? Looks like some scenarios timed out.

@pang-wu
Copy link
Contributor Author

pang-wu commented Dec 23, 2024

@pang-wu, thanks for the PR. This looks good! Can you please check how to pass all the CI tests? Looks like some scenarios timed out.

@carsonwang Looks like we run into a bug in some older spark version, we get the same sparkConfig between tests if we don't reset the fields. I made a workaround to have the tests past, can you take a look?

@pang-wu pang-wu changed the title fix executor custom resource request+support pyarrow >=15 & spark 3.5.2/3 fix executor custom resource request+support pyarrow >=15 & spark 3.5.2/3/4 Dec 25, 2024
Copy link
Collaborator

@carsonwang carsonwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@carsonwang carsonwang merged commit 0466c72 into oap-project:master Dec 26, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants