Skip to content
This repository has been archived by the owner on Jan 3, 2023. It is now read-only.

[SQL-DS-CACHE-38][POAE7-892]update Plasma dependency #39

Merged
merged 3 commits into from
Mar 12, 2021

Conversation

jikunshang
Copy link
Collaborator

What changes were proposed in this pull request?

update Plasma dependency to v3.0.0. Arrow branch

How was this patch tested?

E2E test.

@github-actions
Copy link

Thanks for opening a pull request!

Could you open an issue for this pull request on Github Issues?
https://github.com/oap-project/sql-ds-cache/issues

Then could you also rename pull request title and commit log in the following format?

[SQL-DS-CACHE-${ISSUES_ID}] ${detailed message}

See also:

@jikunshang jikunshang changed the title [sql-ds-cache-38][POAE7-892]update Plasma dependency [SQL-DS-CACHE-38][POAE7-892]update Plasma dependency Mar 11, 2021
@github-actions
Copy link

#38

@winningsix winningsix merged commit f0cd386 into oap-project:master Mar 12, 2021
@winningsix
Copy link

We should bump up to Arrow 3.0.

    <dependency>
      <groupId>com.intel.arrow</groupId>
      <artifactId>arrow-plasma</artifactId>
      <version>0.17.0</version>

@@ -274,6 +274,10 @@
<type>test-jar</type>
<scope>test</scope>
</dependency>
<!--
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@winningsix modified arrow-plasma-3.0.0.jar will not update to mvn central repo. For build purpose, I'd like to keep it here.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How does it work when we release this?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if user want to build by themself, they still use this one. Otherwise user could use jar or so file provided by conda.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got you. So basically, Haifeng team will build one version with Arrow-3.0 and in source code we still use old version. Right?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants