Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ODataUri Completion Fixes #458

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

ODataUri Completion Fixes #458

wants to merge 2 commits into from

Conversation

mikepizzo
Copy link
Contributor

@mikepizzo mikepizzo commented Oct 11, 2023 •
edited
Loading

Fixes:

  • only recommend collection query options for collections -recommend orderby as appropriate
  • don't order by collection-valued properties
  • fix exception requesting completions for top/skip without trailing=
  • don't recommend comma after comma
  • don't suggest additional operators after expression -balance parens

@mikepizzo
Fixes:
58b084a 
-only recommend collection query options for collections
-recommend orderby as appropriate
-don't order by collection-valued properties
-fix exception requesting completions for top/skip without trailing=

todo:
-don't recommend comma after comma
-don't suggest additional operators after expression
-balance parens
@mikepizzo
Fix $select, $expand completions
1ecae01 
still need to:
-fix position for orderby
-fix position for filter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mikepizzo