New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes requested by TC Admin #30

Merged

GeraldKrause merged 1 commit into main from fix/aggregation-csd04

Jul 14, 2023

Contributor

ralfhandl commented Jul 14, 2023

Date should be set to 05 July 2023 (In the subtitle, "Citation format", and in the footers in PDF)
in the PDF, the file name in the footer should include the "v4.0" - thus "odata-data-aggregation-ext-v4.0-csd04"
The HTML, MD, and PDF file names (i.e., the files inside the ZIP) should include the Version and stage:
- odata-data-aggregation-ext-v4.0-csd04.html (or .md or pdf)


Fixes requested by TC Admin

85bbe16

ralfhandl requested review from GeraldKrause and mikepizzo

July 14, 2023 06:29

GeraldKrause approved these changes

View reviewed changes

Contributor

GeraldKrause left a comment

Looks good to me. First point of the review feedback obviously did not require a fix.

GeraldKrause merged commit 301e1eb into main

1 check passed

GeraldKrause deleted the fix/aggregation-csd04 branch

July 14, 2023 10:39

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment