Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Technical content for openc2 command and associated agents, targets, variables #9

Merged
merged 56 commits into from
Jun 26, 2024

Conversation

dlemire60
Copy link
Contributor

@dlemire60 dlemire60 commented Jun 19, 2024

This PR defines:

  • an openc2 CACAO command object
  • agents to support MQTT and HTTPS transfer of OpenC2 messages
  • targets to associate OpenC2 Actuator Profiles with the addressees of OpenC2 messages
  • standard variables to pass parameters to the agents
  • associated supporting content & references

@dlemire60 dlemire60 changed the title Flesh out technical content for openc2 command and associated agents, targets, variable Flesh out technical content for openc2 command and associated agents, targets, variables Jun 19, 2024
@dlemire60 dlemire60 changed the title Flesh out technical content for openc2 command and associated agents, targets, variables Technical content for openc2 command and associated agents, targets, variables Jun 19, 2024
@dlemire60 dlemire60 marked this pull request as ready for review June 25, 2024 16:23
Copy link

@davaya davaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The table in Section 3.1 says "The common workflow step_variables property for an openc2 command MUST include an agent for message transfer." but the example shows the "agent" property and the step_variables property with topics as described in Section 4.

Suggest including both "agent" and "step_variables" in the table Property Names

Copy link

@davaya davaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(first review didn't take)

@dlemire60
Copy link
Contributor Author

Suggest including both "agent" and "step_variables" in the table Property Names

Those aren't in the table for the openc2 action object because they're defined at a higher level in the CACAO spec.

agent_definitions is a playbook property (section 3.1). step_variables is a workflow step common property (section 4.1). It would make sense to add explicit references to make the connection but probably not to repeat the definition in our extension spec. I've tried to align examples in the extension spec with those in the CACAO spec, but sometimes there are ambiguities. I can probably leverage the CACAO Roaster to help with example creation but I'm not fully confident it's completely compliant w/ the v2.0 spec (although that's certainly their stated goal).

@dlemire60
Copy link
Contributor Author

Approved for merging on the 26 June working call.

@dlemire60 dlemire60 merged commit 24cdbc9 into oasis-tcs:working Jun 26, 2024
@dlemire60 dlemire60 deleted the oc2-command branch June 26, 2024 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants