Skip to content
This repository has been archived by the owner on Oct 22, 2023. It is now read-only.

Fix buildkite badge #880

Merged
merged 1 commit into from
Aug 19, 2019
Merged

Conversation

peterjgilbert
Copy link
Member

@peterjgilbert peterjgilbert commented Aug 19, 2019

Specify the branch name for the buildkite badge. Not clear what it refers to when no branch is specified.

@peterjgilbert peterjgilbert requested a review from pro-wh August 19, 2019 19:23
Copy link
Member

@pro-wh pro-wh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well it fixes it, so

@pro-wh
Copy link
Member

pro-wh commented Aug 19, 2019

https://buildkite.com/docs/integrations/build-status-badges#scoping-to-a-branch

By default the build status badge will show the last build’s status

probably from any branch, prior to this change

@peterjgilbert peterjgilbert merged commit e6a9a08 into master Aug 19, 2019
@peterjgilbert peterjgilbert deleted the peterjgilbert/fix/buildkite_badge branch August 19, 2019 19:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants