This repository has been archived by the owner on Oct 22, 2023. It is now read-only.
RFC: remove realpath in symlink_artifacts
#945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
oh duh, this breaks it if you use a relative OASIS_CORE_SRC_PATH |
kostko
reviewed
Oct 21, 2019
peterjgilbert
approved these changes
Oct 22, 2019
Co-Authored-By: Peter Gilbert <pgilbert@oasislabs.com>
pro-wh
force-pushed
the
pro-wh/bugfix/realpath
branch
from
6b92291 to
76e247f
Compare
kostko
approved these changes
Oct 22, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
symlink_artifacts is a script that we'd normally run when first setting up a checkout, before the first successful
makeinvocation. In that state, you wouldn't have atarget/debugdirectory yet, so realpath's requirement "all but the last component must exist" wouldn't be satisfied.The subsequent work in symlink_artifacts, as the name suggests, is to create a symbolic link, so I think the links would still work. At runtime, the links will be followed to
target/debug, and symlinks making up that path would further be resolved. This might even be nice in its own way, so that you could change target/debug without rerunningmake symlink-artifacts.I'm collecting developers' opinions on removing this
realpathcall. Please comment if this would break something you do.