-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cmd/rofl): Add support for building TDX ROFL apps #298
base: master
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for oasisprotocol-cli canceled.
|
e6e597e
to
8bbcd58
Compare
8bbcd58
to
01e0f4e
Compare
9f90623
to
45d7161
Compare
This can now reproduce our measurements for up to 16 vCPUs on QEMU. |
It would be great if we could deterministically compile the ACPI tables, but my brief experiments with ASL did not help. So we are using per-CPU templates for now. |
b091590
to
daa5450
Compare
return 0, err | ||
} | ||
fsSize /= 1024 // Convert to kilobytes. | ||
fsSize = (fsSize * 150) / 100 // Scale by overhead factor of 1.5. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the typical size of the generated filesystems that you've tried so far?
Also, might be a good idea to add a check to make sure that fn
is not an existing block device, so we don't accidentally trash a user's drive :)
(Currently, in the only place this function is called, the filename is hardcoded to rootfs.ext4
, so it's not a problem, but it might be a problem in the future if we maybe have configurable filenames 🤷♂️)
daa5450
to
bda979f
Compare
ac69443
to
3e4ca2c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Following the existing tutorial and running oasis rofl build tdx --mode unsafe
compiled the ROFL, but when it tried to pack it, I got
[built] path+file:///home/oa/rofl-oracle#0.1.0
Preparing stage 2 root filesystem...
Unpacking template...
Adding runtime as init...
Creating ext4 filesystem...
Error: failed to create rootfs image: exit status 1
Do I need to install additional dependencies? No other errors seem to be reported.
Yes, let me add some checks whether the required tools exist. |
57c070f
to
9d1e821
Compare
9d1e821
to
58fc579
Compare
58fc579
to
362edf3
Compare
No description provided.