Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd: Change rust target for building ROFL apps #319

Merged
merged 1 commit into from
Nov 15, 2024
Merged

cmd: Change rust target for building ROFL apps #319

merged 1 commit into from
Nov 15, 2024

Conversation

jberci
Copy link
Contributor

@jberci jberci commented Nov 15, 2024

Some docker images have changed from being based on Alpine to Ubuntu.

@jberci
cmd: Change rust target for building ROFL apps
2fc120d 
Some docker images have changed from being based on Alpine to Ubuntu.
@netlify Netlify
Copy link

netlify bot commented Nov 15, 2024 •
edited
Loading

✅ Deploy Preview for oasisprotocol-cli canceled.

Name Link
🔨 Latest commit 2fc120d
🔍 Latest deploy log https://app.netlify.com/sites/oasisprotocol-cli/deploys/673721ed8159000008d0b68e

@jberci jberci requested a review from matevz November 15, 2024 10:43
@jberci jberci marked this pull request as ready for review November 15, 2024 10:43
matevz
matevz reviewed Nov 15, 2024
View reviewed changes
Copy link
Member

@matevz matevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree. Makes sense since we moved from alpine back to debian in sapphire-localnet and emerald-localnet images.

@jberci jberci merged commit 5c43594 into master Nov 15, 2024
4 checks passed
@jberci jberci deleted the jberci/fix/rofl-target branch November 15, 2024 12:00
@lukaw3d lukaw3d mentioned this pull request Nov 15, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kostko kostko kostko approved these changes

@matevz matevz matevz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jberci @matevz @kostko