Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assemble changes for 1.4.0 release #1098

Merged
merged 1 commit into from
Dec 14, 2023
Merged

Assemble changes for 1.4.0 release #1098

merged 1 commit into from
Dec 14, 2023

Conversation

buberdds
Copy link
Contributor

@buberdds buberdds commented Dec 14, 2023

To fully support NFTs we need to wait for reindexing, but based on Product meeting we want to deploy the latest code this sprint.

Copy link

github-actions bot commented Dec 14, 2023

Deployed to Cloudflare Pages

Latest commit: 6f611c8d1ec004ead260c3e80d44804636422d3d
Status:✅ Deploy successful!
Preview URL: https://507081f6.oasis-explorer.pages.dev

@buberdds buberdds requested a review from tjanez December 14, 2023 10:27
Copy link
Contributor

@csillag csillag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happened to PR #1098?
(The one with the wrong number in the changelog fragment filename)

I dont see it here, with neither the correct nor the wrong number...

@buberdds
Copy link
Contributor Author

buberdds commented Dec 14, 2023

@csillag we don't care about it at the end, because you marked it as trivial. Trivial changes are ignored by towncrier when building changeset. If you want I can add it to internal changes if it is important.

edit: manually added to Internal Changes -> Update API bindings

@buberdds buberdds merged commit 6dd08a9 into master Dec 14, 2023
8 checks passed
@buberdds buberdds deleted the release branch December 14, 2023 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants