Append EVM function name to unencrypted verified contract calls #1516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deployed to Cloudflare Pages
|
lukaw3d
changed the title
|
Added function names in transactions tables Added parameters in transaction details view |
|
TODO:
|
|
Sorry, just to make it formal - this looks good to me @lukaw3d Only nit is for mobile. I think we should vertically align the icon at the top on mobile (see current 'before' image vs the after option). 
|
lukaw3d
commented
Sep 5, 2024
Comment on lines
99
to
166
| if (transaction.to_eth === '0x0100000000000000000000000000000000000103' && transaction.body?.data) { | ||
| // Subcall precompile | ||
| try { | ||
| const coder = AbiCoder.defaultAbiCoder() | ||
| const [methodName, cborHexArgs] = coder.decode(['string', 'bytes'], base64ToHex(transaction.body.data)) | ||
| label += `: ${methodName}` | ||
|
|
||
| if (!truncate) { | ||
| const rawArgs = oasis.misc.fromCBOR(hexToBytes(cborHexArgs)) | ||
| if (rawArgs === null) { | ||
| label += `(null)` | ||
| } else if (typeof rawArgs === 'object' && !Array.isArray(rawArgs)) { | ||
| const jsonArgs = JSON.stringify( | ||
| rawArgs, | ||
| (key, value) => { | ||
| if (value instanceof Uint8Array) { | ||
| if (key === 'from') return oasis.staking.addressToBech32(value) | ||
| if (key === 'to') return oasis.staking.addressToBech32(value) | ||
| if (key === 'shares') return oasis.quantity.toBigInt(value).toLocaleString() | ||
| return `0x${oasis.misc.toHex(value)}` | ||
| } | ||
| if (Array.isArray(value) && value.length === 2) { | ||
| if (key === 'amount') { | ||
| return [ | ||
| oasis.quantity.toBigInt(value[0]).toLocaleString(), | ||
| oasis.misc.toStringUTF8(value[1]), | ||
| ] | ||
| } | ||
| } | ||
| return value | ||
| }, | ||
| 2, | ||
| ) | ||
| label += `(${jsonArgs})` | ||
| } | ||
| } | ||
| } catch (e) { | ||
| console.error('Failed to parse subcall data (might be malformed)', e, transaction) | ||
| } | ||
| } |
There was a problem hiding this comment.
Added subcall cbor parsing, preview https://2bb6e93e.oasis-explorer.pages.dev/testnet/sapphire/tx/0x6e9aae5bc52f6f6f386424a8428e1ae822bd0f64222648fc3208e16591eec10d
|
TODO mocks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #1222