Notification click listener doesn't unsubscribe

[lukaw3d]

oasis-wallet-ext/src/background/service/APIService.js

Lines 688 to 696 in dabb8b4

	let id = hash
	extension.notifications &&
	extension.notifications.onClicked.addListener(function (id) {
	let url = getExplorerUrl() + "transactions/" + id
	openTab(url)
	});
	let title = getLanguage('notificationTitle')
	let message = getLanguage('notificationContent')
	extension.notifications.create(id, {

If user creates 3 transactions (without closing the popup), and clicks on 3rd notification, then it will open 3 duplicate tabs

• listener should probably filter if (id === id) and then removeListener
• I would prefix id with e.g. 'txConfirmed-' + id, so adding different notifications won't cause a conflict

[lukaw3d]

It is slightly better now that it has filtering by ID

oasis-wallet-ext/src/background/service/APIService.js

Lines 767 to 780 in 33f4c7e

	let notifyId = runtimeId ? hash +"?runtime="+runtimeId : hash
	let myNotificationID
	extension.notifications &&
	extension.notifications.onClicked.addListener(function (clickId) {
	if(myNotificationID === clickId){
	let url
	if(runtimeId){
	url = getExplorerUrl() + "paratimes/transactions/" + clickId
	}else{
	url = getExplorerUrl() + "transactions/" + clickId
	}
	openTab(url)
	}
	});