-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add initial support for ParaTimes #156
Conversation
i fix some spell check , but still have |
You can add those exceptions to Lines 9 to 13 in 09a81f6
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've played around with this locally, and depositing works.
I'd like to have us merge this.
Other collaborators here please review too.
#157 |
I discussed with @tjanez and the rest of our team. We'd like to squash some of the commits and merge. |
I'll be squashing the first 10 commits--"add paratime tab" through "add cspell word." I appreciate that you had split up several additions in the first few commits, but the later fixes need to be integrated into those, and those don't apply cleanly to the individual earlier commits. |
e7b6246
to
16c4334
Compare
Removed xlink from the new SVG files. @tjanez do you want to do anything else before merging? I've filed several issues corresponding to things we'd like to do after merging. |
Update: @tjanez will do a pass of review and then merge in the coming days. We're almost there folks! |
Co-authored-by: Warren He <w@oasislabs.com>
16c4334
to
144861b
Compare
Make getSubmitStatus() throw error if StakingAllow transaction doesn't return code: 0.
144861b
to
5f5adc9
Compare
* set deposit | ||
* @param {*} params | ||
*/ | ||
setDeposit= (params)=>{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lvshaoping007 Would these be more correct function names?
APIService.setDeposit // setAllowanceAndDepositToConsensusAccount?
oasis.staking.allowWrapper()
amount = allowanceDifference
APIService.submitTxBody onBroadcastEnd
APIService.onBroadcastEnd // depositToConsensusAccount?
APIService.submitRuntimeBody // submitDepositToConsensusAccountTx?
APIService.buildRuntimeTxBody // buildDepositToConsensusAccountTx?
oasisRT.consensusAccounts.Wrapper.callDeposit()
amount = DEPOSIT_AMOUNT
submitTx
APIService.checkRuntimeTxStatus // createNotificationAfterRuntimeTxSucceeds?
extension.notifications.create
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, i will fix this in next PR , but what does this means , should this be fixed ?
oasis.staking.allowWrapper()
amount = allowanceDifference
oasisRT.consensusAccounts.Wrapper.callDeposit()
amount = DEPOSIT_AMOUNT
submitTx
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think those lines are included for context, and the names used there are fine
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok
1,add Paratime Deposit
2,fix #25