upgrade @oasisprotocol/ledger and related #151
Conversation
pro-wh
requested review from
kostko,
lukaw3d,
peterjgilbert and
tjanez
as code owners
yarn.lock
Outdated
| dependencies: | ||
| "@protobufjs/aspromise" "^1.1.2" | ||
| "@protobufjs/base64" "^1.1.2" | ||
| "@protobufjs/codegen" "^2.0.4" |
There was a problem hiding this comment.
are you telling me a package called "codegen" is a runtime dependency 💀
| "@ledgerhq/logs" "^5.46.0" | ||
|
|
||
| "@ledgerhq/hw-transport-webusb@^5.41.0": | ||
| version "5.53.1" |
There was a problem hiding this comment.
we had two versions of this library before this 💀
|
cc #148 |
pro-wh
force-pushed
the
pro-wh/feature/ledger2
branch
from
6f72de0 to
46fbdf7
Compare
|
note that this puts us over the edge where common.js exists, and the extension won't work in production build |
|
with the upgrade to client 0.1.0-alpha7+, I'm adding a thing to remove the eval ): ): ): |
|
Nice! Still has an issue with building, right? |
|
yup, should still have that issue! |
|
Let's revisit this after #156 |
|
hi , does this version support paratime ? |
|
I'm mostly aware that it adds support for on-chain governance voting. I haven't heard about whether it adds paratime support or not. although the wallet itself doesn't support generating governance voting transactions, this change is mostly to support node operators who upgraded their ledger, so they don't have to downgrade again. |
pro-wh
force-pushed
the
pro-wh/feature/ledger2
branch
from
c9587f5 to
bb277ae
Compare
|
great, we've merged #156, and I've freshened this up. |
pro-wh
force-pushed
the
pro-wh/feature/ledger2
branch
from
bb277ae to
e0744ff
Compare
|
rebased again. now builds |
so we can support version 2.x of the Oasis Ledger app