Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stub out @protobufjs/inquire to avoid unsafe-eval violation in CSP #1774

Merged
merged 1 commit into from
Nov 27, 2023

Conversation

lukaw3d
Copy link
Member

@lukaw3d lukaw3d commented Nov 27, 2023

@lukaw3d lukaw3d requested review from gw0 and buberdds November 27, 2023 16:46
@lukaw3d lukaw3d marked this pull request as ready for review November 27, 2023 16:46
Copy link

github-actions bot commented Nov 27, 2023

Deployed to Cloudflare Pages

Latest commit: ff492aa4638566a64d443240b8896d5dc0443fef
Status:✅ Deploy successful!
Preview URL: https://86825e11.oasis-wallet.pages.dev

Copy link

codecov bot commented Nov 27, 2023

Codecov Report

Merging #1774 (ce76953) into master (e0826e6) will increase coverage by 0.10%.
The diff coverage is 100.00%.

❗ Current head ce76953 differs from pull request most recent head ff492aa. Consider uploading reports for the commit ff492aa to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1774      +/-   ##
==========================================
+ Coverage   81.92%   82.02%   +0.10%     
==========================================
  Files         186      187       +1     
  Lines        4884     4885       +1     
  Branches      897      897              
==========================================
+ Hits         4001     4007       +6     
+ Misses        883      878       -5     
Flag Coverage Δ
cypress 47.56% <100.00%> (+0.01%) ⬆️
jest 77.72% <0.00%> (+0.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/utils/@protobufjs/inquire.js 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

Copy link
Contributor

@pro-wh pro-wh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for finding out how to do this in other build tools

@lukaw3d
Copy link
Member Author

lukaw3d commented Nov 27, 2023

easy
but i'm surprised it didn't break jest tests 🤷

@lukaw3d lukaw3d merged commit d45d397 into master Nov 27, 2023
10 checks passed
@lukaw3d lukaw3d deleted the lw/csp-inquire branch November 27, 2023 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants