Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(app): Allow users to select detail content as text #204

Merged
merged 2 commits into from
Jan 5, 2022
Merged

fix(app): Allow users to select detail content as text #204

merged 2 commits into from
Jan 5, 2022

Conversation

realtimetodie
Copy link
Contributor

Fixes an issue where users could not select detail content as text, eg. the total wallet amount or the transaction record details.

screenshot

pro-wh
pro-wh reviewed Jan 4, 2022
View reviewed changes
Copy link
Contributor

@pro-wh pro-wh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm in favor of the idea

comments on the implementation:

  • moving from vendor prefixed user-select is fine with me

can we get a second reviewer?

lukaw3d
lukaw3d reviewed Jan 5, 2022
View reviewed changes
Copy link
Member

@lukaw3d lukaw3d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good. I'm not sure why most of the UI was made non-selectable.

(From the screenshot it looks like the idea might be to be able to copy and transfer full balance.. I'm not completely confident there's no rounding going on there.)

@pro-wh
Copy link
Contributor

pro-wh commented Jan 5, 2022

alright, I'll see if I can rebase and merge

realtimetodie and others added 2 commits January 4, 2022 16:24
@realtimetodie @pro-wh
fix(app): Allow users to select detail content as text
59e6c66 
Fixes an issue where users could not select detail content as text, eg. the
total wallet amount or the transaction record details
@pro-wh
add changelog
2d13f03
@pro-wh
Copy link
Contributor

pro-wh commented Jan 5, 2022

wrapped commit message to fix lint. added a changelog entry too

@pro-wh pro-wh merged commit 3a0bcad into oasisprotocol:master Jan 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukaw3d lukaw3d lukaw3d left review comments

@pro-wh pro-wh pro-wh approved these changes

@kostko kostko Awaiting requested review from kostko kostko is a code owner

@peterjgilbert peterjgilbert Awaiting requested review from peterjgilbert peterjgilbert is a code owner

@tjanez tjanez Awaiting requested review from tjanez tjanez is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@realtimetodie @pro-wh @lukaw3d