Only show hardcoded paratimes #267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukaw3d
requested review from
pro-wh,
peterjgilbert,
kostko and
tjanez
as code owners
gw0
approved these changes
May 10, 2022
| } | ||
| } | ||
| } | ||
| return runtimeConfig |
There was a problem hiding this comment.
Although this is implicit behavior, but it would be cleaner to explicitly write: return null (or return {})?
There was a problem hiding this comment.
Yep, and typescript correctly infers the type too. Added return undefined.
(the whole getRuntimeConfig is bad code tho. Something to improve in wallet v2)
lukaw3d
force-pushed
the
lw/only-hardcoded-paratimes
branch
from
6389c47 to
0fb12f3
Compare
pro-wh
approved these changes
May 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testnet already has an unknown runtime registered, and it throws
Error: client: no hosted runtime is availablewhen wallet tries to query its accounts.Balances. Hide it for now.