Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warn about not storing mnemonic in next version #316

Merged
merged 5 commits into from
Sep 4, 2023
Merged

Warn about not storing mnemonic in next version #316

merged 5 commits into from
Sep 4, 2023

Conversation

buberdds
Copy link
Contributor

@buberdds buberdds commented Aug 29, 2023 •
edited
Loading

  • The release date in the configuration will be provided in a future release. I don't expect we will release new ext soon.
  • Show a warning indicator only in the Create/Restore wallet, Open Wallet/Lock, and Wallet (after opening the wallet) views.
  • Provide an option to dismiss a warning.
  • Dismissing is not available when it's close to the release date (3 days), and the indicator is always visible no matter if it was dismissed.
  • When a release date is provided, reset the user's dismiss setting if it was set more than 2 weeks before the release date.

@buberdds buberdds force-pushed the mz/newExtWarning branch 2 times, most recently from 4f699b2 to 5a03395 Compare August 30, 2023 10:56
@buberdds buberdds marked this pull request as ready for review August 30, 2023 11:03
lukaw3d
lukaw3d approved these changes Sep 1, 2023
View reviewed changes
src/popup/component/NewExtensionWarning/index.js Outdated Show resolved Hide resolved
@buberdds buberdds merged commit 1ff023d into oasisprotocol:master Sep 4, 2023
@buberdds buberdds mentioned this pull request Oct 3, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukaw3d lukaw3d lukaw3d approved these changes

@pro-wh pro-wh Awaiting requested review from pro-wh pro-wh is a code owner

@peterjgilbert peterjgilbert Awaiting requested review from peterjgilbert peterjgilbert is a code owner

@kostko kostko Awaiting requested review from kostko kostko is a code owner

@tjanez tjanez Awaiting requested review from tjanez tjanez is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@buberdds @lukaw3d