docs: SIWE tutorial and Solidity polishes #459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for oasisprotocol-sapphire-paratime canceled.
|
matevz
force-pushed
the
matevz/docs/siwe-tutorial
branch
4 times, most recently
from
0c345f4 to
64b3602
Compare
matevz
force-pushed
the
matevz/docs/siwe-tutorial
branch
from
64b3602 to
ea39756
Compare
matevz
force-pushed
the
matevz/docs/siwe-tutorial
branch
2 times, most recently
from
ffd51aa to
6538060
Compare
ZigaMr
reviewed
Nov 26, 2024
aefhm
reviewed
Nov 27, 2024
aefhm
reviewed
Nov 28, 2024
aefhm
reviewed
Nov 29, 2024
rube-de
requested changes
Dec 2, 2024
matevz
force-pushed
the
matevz/docs/siwe-tutorial
branch
from
6538060 to
a581f82
Compare
aefhm
approved these changes
Jan 7, 2025
matevz
force-pushed
the
matevz/docs/siwe-tutorial
branch
3 times, most recently
from
78f0b9d to
3daa8d0
Compare
matevz
force-pushed
the
matevz/docs/siwe-tutorial
branch
from
3daa8d0 to
50a1a75
Compare
matevz
force-pushed
the
matevz/docs/siwe-tutorial
branch
from
50a1a75 to
1339038
Compare
rube-de
approved these changes
Jan 31, 2025
matevz
force-pushed
the
matevz/docs/siwe-tutorial
branch
from
1339038 to
ff3722e
Compare
github-actions bot
added a commit
that referenced
this pull request
Jan 31, 2025
…l/matevz/docs/siwe-tutorial docs: SIWE tutorial and Solidity polishes 7b688e7
github-actions bot
added a commit
that referenced
this pull request
Jan 31, 2025
…atevz/docs/siwe-tutorial docs: SIWE tutorial and Solidity polishes 7b688e7
github-actions bot
added a commit
that referenced
this pull request
Jan 31, 2025
…tevz/docs/siwe-tutorial docs: SIWE tutorial and Solidity polishes 7b688e7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #338
Solidity sapphire-contracts related updates:
calldata bearertobytes bearerso it can be passed as empty, if none available (e.g. in case you want to call a common isContractOwner() modifier in your setter methods where you don't use SIWE, but msg.sender directly)bearertoauthTokenbecause the bearer token uses a specialized format which we don'tAuthbefore auth-related errors so they are more unique in the complex contractsPREVIEW
Future TODO
Could we adopt ERC-2771 naming conventions and flow? Replacing
authMsgSender()with_msgSenderis one option. What about appending the token after the calldata? ERC-2771 uses this for transactions, but would this work for the queries too? Can you use ERC-2771 seamlessly like writingmyContract.getSomeSensitiveInfo()in your client code without special hacks involving appending the authToken at the end of callData manually each time?