Merge pull request #2122 from oasisprotocol/lw/fix-missing-validators

Fix getting all validators from nexus (defaulted to first 100)
oasisprotocol · Feb 19, 2025 · 24366d9 · 24366d9
2 parents 94420f5 + 99304cf
commit 24366d9
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 4 deletions.
diff --git a/.changelog/2122.bugfix.md b/.changelog/2122.bugfix.md
@@ -0,0 +1 @@
+Display all validators, not just first 100
diff --git a/playwright/tests/validators.spec.ts b/playwright/tests/validators.spec.ts
@@ -9,7 +9,7 @@ test.beforeEach(async ({ page }) => {
   await warnSlowApi(page)
   await mockApi(page, '500000000000')
   // Unmock validators list API
-  await page.unroute('**/consensus/validators')
+  await page.unroute('**/consensus/validators?*')
   await expectNoErrorsInConsole(page, {
     ignoreError: message => {
       // Some validator icons need authentication

diff --git a/playwright/utils/mockApi.ts b/playwright/utils/mockApi.ts
@@ -65,7 +65,7 @@ export async function mockApi(context: BrowserContext | Page, balance: number |
       }),
     })
   })
-  await context.route('**/consensus/validators', route => {
+  await context.route('**/consensus/validators?*', route => {
     route.fulfill({
       body: JSON.stringify({
         is_total_count_clipped: false,
@@ -201,7 +201,7 @@ export async function mockApiMoreData(context: BrowserContext | Page) {
       }),
     })
   })
-  await context.route('**/consensus/validators', route => {
+  await context.route('**/consensus/validators?*', route => {
     route.fulfill({
       body: JSON.stringify({
         is_total_count_clipped: false,

diff --git a/src/vendors/nexus.ts b/src/vendors/nexus.ts
@@ -43,7 +43,7 @@ export function getNexusAPIs(url: string | 'https://nexus.oasis.io/v1/') {
   }
 
   async function getAllValidators(): Promise<Validator[]> {
-    const validatorsResponse = await api.consensusValidatorsGet({})
+    const validatorsResponse = await api.consensusValidatorsGet({ limit: 1000 })
     if (!validatorsResponse) throw new Error('Wrong response code')
 
     return parseValidatorsList(validatorsResponse.validators)