Skip to content

Conversation

@overthink
Copy link
Contributor

@overthink overthink commented Nov 3, 2025

If you run the echo example with go run adapter/echoopenapi/examples/basic/main.go, prior to this patch you'd get a 404 from:

curl --request POST \
  --url http://localhost:3000/api/v1/login \
  --header 'Accept: application/json' \
  --header 'Content-Type: application/json' \
  --data '{
  "password": "foo",
  "username": "bar"
}'

With this fix you get a response.

However, the fixed response reveals a deeper issue: in Echo you sepcify path params with the param struct tag, not path. So The above request now returns {"id":"","name":"John Doe"} but we expect {"id":"123","name":"John Doe"}. I'll raise this separately in an issue.

@codecov
Copy link

codecov bot commented Nov 4, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@akfaiz akfaiz merged commit 3e0fa0d into oaswrap:main Nov 4, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants