fix: echo route syntax uses :id not {id}
#39
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you run the echo example with
go run adapter/echoopenapi/examples/basic/main.go, prior to this patch you'd get a 404 from:With this fix you get a response.
However, the fixed response reveals a deeper issue: in Echo you sepcify path params with the
paramstruct tag, notpath. So The above request now returns{"id":"","name":"John Doe"}but we expect{"id":"123","name":"John Doe"}. I'll raise this separately in an issue.