Fix panic when BLS key is nothing & support multiple keys #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tak1827
approved these changes
Oct 18, 2024
tak1827
added a commit
that referenced
this pull request
Oct 31, 2024
* copy new files from bsc@v1.4.6 * copy from bsc v1.4.6 * resolve interface missing method error for mock structs * apply finality to our consensus * add oasys consensus test: env/validators assemble * whether broadcast vote judging from peers's TD * fix lots of error to make work voting * increase vote DOS threadhold * fix lint error * modify go.mod according to BSC * vote attestaion stake weighted * add MaliciousVoteMonitor * remove bsc dependent comments/message * rename finalizer to fast finality * replace genesis contract by v1.6.0 * update genesis contract submodule (v1.6.0) * resolved several consensus issue * increment version to v1.6.0 * print error log: prepareWork and commit * print warn log in case of invalid vote * sort validators by owner for fast finality * apply validators sort changes to snapshot.go * disable deployments11 * refactor consensus * upgrade stake manager contract version * delete unused CeilDiv function * delete unused metrics.label file copyed from bsc * add comment to formHeader of finalize and seal case * add comment why disable fromHeader on Finalize * fix mainnet sync error: failed to verify header * fix getValidators marshal error by suppporting old contract interface * commit leak of previous one * fix verify header error by adding missing return * deal with unexpected value is presented to callGetHighStakesCommon * fix getHighStakes unpack error. replace wrong contract * sort by owner only fast finality enabled * Improved performance degradation due to change in json format of consensus snapshot * Improved EnvironmentValue parsing (#70) * Add note to BLSPublicKey's Marshaler * fix null pointer error after taking #69 * temporary set testnet hardfork for private testnet * increase private testnet hardork block * bring private hardfork time closer * fix feedback from @ironbeer part1 * vot validator point to parent block(=target block) * Add contract deploy test * Update consensus/oasys/snapshot.go Co-authored-by: ironbeer <7997273+ironbeer@users.noreply.github.com> * fix feedback from ironbeer part2 * Added `Equal` method to EnvironmentValue (#71) * Imported diffs of blockchain.go and headerchain.go from bsc@v1.4.6 (#74) * Imported diffs of blockchain.go and headerchain.go from bsc@v1.4.6 * Imported fast finality reorganization from bsc@v1.4.6 (#75) * Imported fast finality reorganization from bsc@v1.4.6 * Fix errors in test code * elaborate the timeing update finalized and justified gauge (#77) --------- Co-authored-by: tak <re795h@gmail.com> * Fix panic when BLS key is nothing & support multiple keys (#81) * Imported eth.handler from bsc@v1.4.6 (#78) * Imported stop process of eth.handler from bsc@v1.4.6 * Imported `chainFinalizedHeightFn` of fetcher.BlockFetcher from bsc@v1.4.6 * remove stop chan from eth/handler (#82) --------- Co-authored-by: tak <re795h@gmail.com> * fix feadback from ironbeer part3 * Fix reorg when justification chain is split (#85) * update loas contract & reset testnet hardfork schedule * Fix misc (#87) * Fix test error * Fix image build error --------- Co-authored-by: ironbeer <7997273+ironbeer@users.noreply.github.com>
tak1827
added a commit
that referenced
this pull request
Oct 31, 2024
* Configured block time shortening epoch for the mainnet * Fix block time shortening epoch for the mainnet * Feat/finalizer (#61) * copy new files from bsc@v1.4.6 * copy from bsc v1.4.6 * resolve interface missing method error for mock structs * apply finality to our consensus * add oasys consensus test: env/validators assemble * whether broadcast vote judging from peers's TD * fix lots of error to make work voting * increase vote DOS threadhold * fix lint error * modify go.mod according to BSC * vote attestaion stake weighted * add MaliciousVoteMonitor * remove bsc dependent comments/message * rename finalizer to fast finality * replace genesis contract by v1.6.0 * update genesis contract submodule (v1.6.0) * resolved several consensus issue * increment version to v1.6.0 * print error log: prepareWork and commit * print warn log in case of invalid vote * sort validators by owner for fast finality * apply validators sort changes to snapshot.go * disable deployments11 * refactor consensus * upgrade stake manager contract version * delete unused CeilDiv function * delete unused metrics.label file copyed from bsc * add comment to formHeader of finalize and seal case * add comment why disable fromHeader on Finalize * fix mainnet sync error: failed to verify header * fix getValidators marshal error by suppporting old contract interface * commit leak of previous one * fix verify header error by adding missing return * deal with unexpected value is presented to callGetHighStakesCommon * fix getHighStakes unpack error. replace wrong contract * sort by owner only fast finality enabled * Improved performance degradation due to change in json format of consensus snapshot * Improved EnvironmentValue parsing (#70) * Add note to BLSPublicKey's Marshaler * fix null pointer error after taking #69 * temporary set testnet hardfork for private testnet * increase private testnet hardork block * bring private hardfork time closer * fix feedback from @ironbeer part1 * vot validator point to parent block(=target block) * Add contract deploy test * Update consensus/oasys/snapshot.go Co-authored-by: ironbeer <7997273+ironbeer@users.noreply.github.com> * fix feedback from ironbeer part2 * Added `Equal` method to EnvironmentValue (#71) * Imported diffs of blockchain.go and headerchain.go from bsc@v1.4.6 (#74) * Imported diffs of blockchain.go and headerchain.go from bsc@v1.4.6 * Imported fast finality reorganization from bsc@v1.4.6 (#75) * Imported fast finality reorganization from bsc@v1.4.6 * Fix errors in test code * elaborate the timeing update finalized and justified gauge (#77) --------- Co-authored-by: tak <re795h@gmail.com> * Fix panic when BLS key is nothing & support multiple keys (#81) * Imported eth.handler from bsc@v1.4.6 (#78) * Imported stop process of eth.handler from bsc@v1.4.6 * Imported `chainFinalizedHeightFn` of fetcher.BlockFetcher from bsc@v1.4.6 * remove stop chan from eth/handler (#82) --------- Co-authored-by: tak <re795h@gmail.com> * fix feadback from ironbeer part3 * Fix reorg when justification chain is split (#85) * update loas contract & reset testnet hardfork schedule * Fix misc (#87) * Fix test error * Fix image build error --------- Co-authored-by: ironbeer <7997273+ironbeer@users.noreply.github.com> * set testnet hardfork for v1.6.0 (#88) --------- Co-authored-by: ironbeer <7997273+ironbeer@users.noreply.github.com>
tak1827
added a commit
that referenced
this pull request
Oct 31, 2024
* Configured block time shortening epoch for the mainnet * Fix block time shortening epoch for the mainnet * Feat/finalizer (#61) * copy new files from bsc@v1.4.6 * copy from bsc v1.4.6 * resolve interface missing method error for mock structs * apply finality to our consensus * add oasys consensus test: env/validators assemble * whether broadcast vote judging from peers's TD * fix lots of error to make work voting * increase vote DOS threadhold * fix lint error * modify go.mod according to BSC * vote attestaion stake weighted * add MaliciousVoteMonitor * remove bsc dependent comments/message * rename finalizer to fast finality * replace genesis contract by v1.6.0 * update genesis contract submodule (v1.6.0) * resolved several consensus issue * increment version to v1.6.0 * print error log: prepareWork and commit * print warn log in case of invalid vote * sort validators by owner for fast finality * apply validators sort changes to snapshot.go * disable deployments11 * refactor consensus * upgrade stake manager contract version * delete unused CeilDiv function * delete unused metrics.label file copyed from bsc * add comment to formHeader of finalize and seal case * add comment why disable fromHeader on Finalize * fix mainnet sync error: failed to verify header * fix getValidators marshal error by suppporting old contract interface * commit leak of previous one * fix verify header error by adding missing return * deal with unexpected value is presented to callGetHighStakesCommon * fix getHighStakes unpack error. replace wrong contract * sort by owner only fast finality enabled * Improved performance degradation due to change in json format of consensus snapshot * Improved EnvironmentValue parsing (#70) * Add note to BLSPublicKey's Marshaler * fix null pointer error after taking #69 * temporary set testnet hardfork for private testnet * increase private testnet hardork block * bring private hardfork time closer * fix feedback from @ironbeer part1 * vot validator point to parent block(=target block) * Add contract deploy test * Update consensus/oasys/snapshot.go Co-authored-by: ironbeer <7997273+ironbeer@users.noreply.github.com> * fix feedback from ironbeer part2 * Added `Equal` method to EnvironmentValue (#71) * Imported diffs of blockchain.go and headerchain.go from bsc@v1.4.6 (#74) * Imported diffs of blockchain.go and headerchain.go from bsc@v1.4.6 * Imported fast finality reorganization from bsc@v1.4.6 (#75) * Imported fast finality reorganization from bsc@v1.4.6 * Fix errors in test code * elaborate the timeing update finalized and justified gauge (#77) --------- Co-authored-by: tak <re795h@gmail.com> * Fix panic when BLS key is nothing & support multiple keys (#81) * Imported eth.handler from bsc@v1.4.6 (#78) * Imported stop process of eth.handler from bsc@v1.4.6 * Imported `chainFinalizedHeightFn` of fetcher.BlockFetcher from bsc@v1.4.6 * remove stop chan from eth/handler (#82) --------- Co-authored-by: tak <re795h@gmail.com> * fix feadback from ironbeer part3 * Fix reorg when justification chain is split (#85) * update loas contract & reset testnet hardfork schedule * Fix misc (#87) * Fix test error * Fix image build error --------- Co-authored-by: ironbeer <7997273+ironbeer@users.noreply.github.com> * set testnet hardfork for v1.6.0 (#88) * Fix voting process stopping with each synchronization (#90) * Fix nil panic in td.Cmp(bestTd) * Fix voting process stopping with each synchronization. RelatedCode: - eth/downloader/downloader.go#L463 - core/vote/vote_manager.go#L108-L110) --------- Co-authored-by: ironbeer <7997273+ironbeer@users.noreply.github.com>
tak1827
added a commit
that referenced
this pull request
Dec 1, 2024
* params: begin v1.13.9 release cycle * core/state: logic equivalence for GetCodeHash (#28733) * tests: add currentExcessBlobGas to state tests (#28735) * accounts,signer: fix typos in comments (#28730) * build: add support for ubuntu 23.10 (mantic minotaur) (#28728) * log: avoid setting default slog logger in init (#28747) slog.SetDefault has undesirable side effects. It also sets the default logger destination, for example. So we should not call it by default in init. * cmd/evm: fix link in README.md (#28755) * core/vm: update comments to match eip number (#28743) * cmd/evm: Fix blob-gas-used on invalid transactions in t8n (#28734) cmd/evm: fixes the blob gas calculation if a transaction is invalid * internal/flags: update copyright year to 2024 (#28760) Co-authored-by: Felix Lange <fjl@twurst.com> * ethclient: simplify error handling in TransactionReceipt (#28748) Co-authored-by: Martin HS <martin@swende.se> Co-authored-by: Felix Lange <fjl@twurst.com> * eth/downloader, eth/filters: use defer to call Unsubscribe (#28762) * log: emit error level string as "error", not "eror" (#28774) * eth/filters: fix early Unsubscribe of log events (#28769) * cmd/devp2p/internal/ethtest: fix typos in comments (#28772) * params, core/forkid: schedule cancun fork on goerli (#28719) This PR schedules the cancun fork for the goerli testnet as discussed on ACD. Spec: ethereum/execution-specs#860 We schedule: goerli at 1705473120 * cmd/geth: make it possible to autopilot removedb (#28725) When managing geth, it is sometimes desirable to do a partial wipe; deleting state but retaining freezer data. A partial wipe can be somewhat tricky to accomplish. This change implements the ability to perform partial wipe by making it possible to run geth removedb non-interactive, using command line options instead. * accounts/abi: fix bigInt topic encoding (#28764) * cmd/geth: update log test data (#28780) update logger test data * ethclient/simulated: implement new sim backend (#28202) This is a rewrite of the 'simulated backend', an implementation of the ethclient interfaces which is backed by a simulated blockchain. It was getting annoying to maintain the old version of the simulated backend feature because there was a lot of code duplication with the main client. The new version is built using parts that we already have: an in-memory geth node instance running in developer mode provides the chain, while the Go API is provided by ethclient. A backwards-compatibility wrapper is provided, but the simulated backend has also moved to a more sensible import path: github.com/ethereum/go-ethereum/ethclient/simulated --------- Co-authored-by: Felix Lange <fjl@twurst.com> Co-authored-by: Gary Rong <garyrong0905@gmail.com> * params: go-ethereum v1.13.9 stable * params: begin v1.13.10 release cycle * version: release v1.13.10 to fix bad tag * params: begin v1.13.11 release cycle * docs: fix badge in README (#28796) * Fix broken badge in README.md Replaced broken Github link with IPFS link for long-term storage. * update go badge Co-authored-by: lightclient <14004106+lightclient@users.noreply.github.com> --------- Co-authored-by: lightclient <14004106+lightclient@users.noreply.github.com> * eth: minor change of config-accessor (#28782) eth: refactor `GetVM` * cmd: fix typos (#28798) * build: fix typo in comment (#28800) * accounts, ethclient: minor tweaks on the new simulated backend (#28799) * accounts, ethclient: minor tweaks on the new simulated backend * ethclient/simulated: add an initial batch of gas options * accounts, ethclient: remove mandatory gasLimit constructor param * accounts, ethclient: minor option naming tweaks * cmd/geth, internal/debug: get rid of by-default log config (#28801) * cmd/devp2p/internal/ethtest: skip large tx test on github build (#28794) This test was failling consistently on the github 32-bit build probably due to slow IO. Skipping it for that green check. * p2p/dnsdisc: use strings.Cut over strings.IndexByte (#28787) * internal/ethapi: avoid using pending for defaults (#28784) Given the discussions around deprecating pending (see #28623 or ethereum/execution-apis#495), we can move away from using the pending block internally, and use latest instead * core/state: unexport GetOrNewStateObject (#28804) * cmd/rlpdump: add -pos flag, displaying byte positions (#28785) * tests: update reference tests (#28778) Updates the reference tests to the latest version * ethclient: add tests for TransactionInBlock (#28283) Co-authored-by: Felix Lange <fjl@twurst.com> * eth: fix potential hang in waitSnapExtension (#28744) This should fix a rare hang in waitSnapExtension during shutdown. * core/txpool/blobpool: fix typos * acounts/usbwallet: fix typo (#28815) acounts:fix typo * tests: more verbosity if block decoding fails (#28814) * tracer: use proper base fee in tests (#28775) In the tracing tests, the base fee was generally set to nil. This commit changes this to pass the proper base instead, and fixes the few tests which become broken by the change. * miner: fix typo in payload_building_test.go (#28825) * internal/ethapi: handle blobs in API methods (#28786) EIP-4844 adds a new transaction type for blobs. Users can submit such transactions via `eth_sendRawTransaction`. In this PR we refrain from adding support to `eth_sendTransaction` and in fact it will fail if the user passes in a blob hash. However since the chain can handle such transactions it makes sense to allow simulating them. E.g. an L2 operator should be able to simulate submitting a rollup blob and updating the L2 state. Most methods that take in a transaction object should recognize blobs. The change boils down to adding `blobVersionedHashes` and `maxFeePerBlobGas` to `TransactionArgs`. In summary: - `eth_sendTransaction`: will fail for blob txes - `eth_signTransaction`: will fail for blob txes The methods that sign txes does not, as of this PR, add support the for new EIP-4844 transaction types. Resuming the summary: - `eth_sendRawTransaction`: can send blob txes - `eth_fillTransaction`: will fill in a blob tx. Note: here we simply fill in normal transaction fields + possibly `maxFeePerBlobGas` when blobs are present. One can imagine a more elaborate set-up where users can submit blobs themselves and we fill in proofs and commitments and such. Left for future PRs if desired. - `eth_call`: can simulate blob messages - `eth_estimateGas`: blobs have no effect here. They have a separate unit of gas which is not tunable in the transaction. * eth/filters: reset filter.begin in BenchmarkFilters (#28830) * crypto/kzg4844: add helpers for versioned blob hashes (#28827) The code to compute a versioned hash was duplicated a couple times, and also had a small issue: if we ever change params.BlobTxHashVersion, it will most likely also cause changes to the actual hash computation. So it's a bit useless to have this constant in params. * ethclient: apply accessList field in toCallArg (#28832) Co-authored-by: Felix Lange <fjl@twurst.com> * params, core/forkid: enable cancun on sepolia and holesky (#28834) This change enables Cancun - Sepolia at 1706655072 (Jan 31st, 2024) - Holesky at 1707305664 (Feb 7th, 2024) Specification: ethereum/execution-specs#860 * core, core/rawdb, eth/sync: no tx indexing during snap sync (#28703) This change simplifies the logic for indexing transactions and enhances the UX when transaction is not found by returning more information to users. Transaction indexing is now considered as a part of the initial sync, and `eth.syncing` will thus be `true` if transaction indexing is not yet finished. API consumers can use the syncing status to determine if the node is ready to serve users. * docs: remove reference to being official (#28858) * go.{mod,sum}: upgrade go-ole to support arm64 (#28859) go.{mod,sum}: upgrade go-ole * core: fix genesis setup in benchReadChain (#28856) * all: use uint256 in state (#28598) This change makes use of uin256 to represent balance in state. It touches primarily upon statedb, stateobject and state processing, trying to avoid changes in transaction pools, core types, rpc and tracers. * build: upgrade -dlgo version to Go 1.21.6 (#28836) * core/state/snapshot: use AddHash/ContainHash instead of Hasher interface (#28849) This change switches from using the `Hasher` interface to add/query the bloomfilter to implementing it as methods. This significantly reduces the allocations for Search and Rebloom. * core/vm: fix misleading comment (#28860) fix misleading comment * eth/catalyst: add timestamp checks to fcu and new payload and improve param checks (#28230) This PR introduces a few changes with respect to payload verification in fcu and new payload requests: * First of all, it undoes the `verifyPayloadAttributes(..)` simplification I attempted in #27872. * Adds timestamp validation to fcu payload attributes [as required](https://github.com/ethereum/execution-apis/blob/main/src/engine/cancun.md#specification-1) (section 2) by the Engine API spec. * For the new payload methods, I also update the verification of the executable data. For `newPayloadV2`, it does not currently ensure that cancun values are `nil`. Which could make it possible to submit cancun payloads through it. * On `newPayloadV3` the same types of checks are added. All shanghai and cancun related fields in the executable data must be non-nil, with the addition that the timestamp is _only_ with cancun. * Finally it updates a newly failing catalyst test to call the correct fcu and new payload methods depending on the fork. * core/txpool, eth/catalyst: fix racy simulator due to txpool background reset (#28837) This PR fixes an issues in the new simulated backend. The root cause is the fact that the transaction pool has an internal reset operation that runs on a background thread. When a new transaction is added to the pool via the RPC, the transaction is added to a non-executable queue and will be moved to its final location on a background thread. If the machine is overloaded (or simply due to timing issues), it can happen that the simulated backend will try to produce the next block, whilst the pool has not yet marked the newly added transaction executable. This will cause the block to not contain the transaction. This is an issue because we want determinism from the simulator: add a tx, mine a block. It should be in there. The PR fixes it by adding a Sync function to the txpool, which waits for the current reset operation (if any) to finish, and then runs an entire round of reset on top. The new round is needed because resets are only triggered by new head events, so newly added transactions will not trigger the outer resets that we can wait on. The transaction pool would eventually internally do a reset even on transaction addition, but there's no easy way to wait on that and there's no meaningful reason to bubble that across everything. A clean outer reset will at worse be a small noop goroutine. * core: move tx indexer to its own file (#28857) This change moves all the transaction indexing functions to a separate txindexer.go file and defines a txIndexer structure as a refactoring. * eth/catalyst: prefix payload id with version (#28246) GetPayloadVX should only return payloads which match its version. GetPayloadV2 is a special snowflake that supports v1 and v2 payloads. This change uses a a version-specific prefix within in the payload id, basically a namespace for the version number. * ethclient: fix flaky test (#28864) Fix flaky test due to incomplete transaction indexing * params: go-ethereum v1.13.11 stable * params: begin v.1.13.12 release cycle * internal/flags: fix typo (#28876) * core/types: fix and test handling of faulty nil-returning signer (#28879) This adds an error if the signer returns a nil value for one of the signature value fields. * README.md: fix travis badge (#28889) The hyperlink in the README file that directs to the Travis CI build was broken. This commit updates the link to point to the corrent build page. * eth/catalyst: allow payload attributes v1 in fcu v2 (#28882) At some point, `ForkchoiceUpdatedV2` stopped working for `PayloadAttributesV1` while `paris` was active. This was causing a few failures in hive. This PR fixes that, and also adds a gate in `ForkchoiceUpdatedV1` to disallow `PayloadAttributesV3`. * docs/postmortems: fix outdated link (#28893) * core: reset tx lookup cache if necessary (#28865) This pull request resets the txlookup cache if chain reorg happens, preventing them from remaining reachable. It addresses failures in the hive tests. * build: fix problem with windows line-endings in CI download (#28900) fixes #28890 * eth/downloader: fix skeleton cleanup (#28581) * eth/downloader: fix skeleton cleanup * eth/downloader: short circuit if nothing to delete * eth/downloader: polish the logic in cleanup * eth/downloader: address comments * deps: update memsize (#28916) * core/txpool/blobpool: post-crash cleanup and addition/removal metrics (#28914) * core/txpool/blobpool: clean up resurrected junk after a crash * core/txpool/blobpool: track transaction insertions and rejections * core/txpool/blobpool: linnnnnnnt * core/txpool: don't inject lazy resolved transactions into the container (#28917) * core/txpool: don't inject lazy resolved transactions into the container * core/txpool: minor typo fixes * core/types: fix typo (#28922) * p2p: fix accidental termination of portMappingLoop (#28911) * internal/flags: fix --miner.gasprice default listing (#28932) * all: fix typos in comments (#28881) * Makefile: add help target to display available targets (#28845) Co-authored-by: Martin HS <martin@swende.se> Co-authored-by: Felix Lange <fjl@twurst.com> * core: cache transaction indexing tail in memory (#28908) * eth, miner: fix enforcing the minimum miner tip (#28933) * eth, miner: fix enforcing the minimum miner tip * ethclient/simulated: fix failing test due the min tip change * accounts/abi/bind: fix simulater gas tip issue * core/state, core/vm: minor uint256 related perf improvements (#28944) * cmd,internal/era: implement `export-history` subcommand (#26621) * all: implement era format, add history importer/export * internal/era/e2store: refactor e2store to provide ReadAt interface * internal/era/e2store: export HeaderSize * internal/era: refactor era to use ReadAt interface * internal/era: elevate anonymous func to named * cmd/utils: don't store entire era file in-memory during import / export * internal/era: better abstraction between era and e2store * cmd/era: properly close era files * cmd/era: don't let defers stack * cmd/geth: add description for import-history * cmd/utils: better bytes buffer * internal/era: error if accumulator has more records than max allowed * internal/era: better doc comment * internal/era/e2store: rm superfluous reader, rm superfluous testcases, add fuzzer * internal/era: avoid some repetition * internal/era: simplify clauses * internal/era: unexport things * internal/era,cmd/utils,cmd/era: change to iterator interface for reading era entries * cmd/utils: better defer handling in history test * internal/era,cmd: add number method to era iterator to get the current block number * internal/era/e2store: avoid double allocation during write * internal/era,cmd/utils: fix lint issues * internal/era: add ReaderAt func so entry value can be read lazily Co-authored-by: lightclient <lightclient@protonmail.com> Co-authored-by: Martin Holst Swende <martin@swende.se> * internal/era: improve iterator interface * internal/era: fix rlp decode of header and correctly read total difficulty * cmd/era: fix rebase errors * cmd/era: clearer comments * cmd,internal: fix comment typos --------- Co-authored-by: Martin Holst Swende <martin@swende.se> * core,params: add holesky to default genesis function (#28903) * node, rpc: add configurable HTTP request limit (#28948) Adds a configurable HTTP request limit, and bumps the engine default * all: fix docstring names (#28923) * fix wrong comment * reviewers input * Update log/handler_glog.go --------- Co-authored-by: Martin HS <martin@swende.se> * ethclient/simulated: fix typo (#28952) (ethclient/simulated):fix typo * eth/gasprice: fix percentile validation in eth_feeHistory (#28954) * cmd/devp2p, eth: drop support for eth/67 (#28956) * params, core/forkid: add mainnet timestamp for Cancun (#28958) * params: add cancun timestamp for mainnet * core/forkid: add test for mainnet cancun forkid * core/forkid: update todo tests for cancun * internal/ethapi: add support for blobs in eth_fillTransaction (#28839) This change adds support for blob-transaction in certain API-endpoints, e.g. eth_fillTransaction. A follow-up PR will add support for signing such transactions. * internal/era: update block index format to be based on record offset (#28959) As mentioned in #26621, the block index format for era1 is not in line with the regular era block index. This change modifies the index so all relative offsets are based against the beginning of the block index record. * params: go-ethereum v1.13.12 stable * params: begin v1.13.13 release cycle * build: remove ubuntu 'lunar' build (#28962) * fix: update outdated link to trezor docs (#28966) fix: update link to trezor * internal/ethapi: fix gas estimation bug in eth_fillTransaction for blob tx (#28929) * core/txpool/legacypool: use uint256.Int instead of big.Int (#28606) This change makes the legacy transaction pool use of `uint256.Int` instead of `big.Int`. The changes are made primarily only on the internal functions of legacypool. --------- Co-authored-by: Martin Holst Swende <martin@swende.se> * internal/ethapi, signer/core: fix documentation-links (#28979) fix: management api links * all: remove the dependency from trie to triedb (#28824) This change removes the dependency from trie package to triedb package. * cmd/utils: fix merge-breakage in test (#28985) * tests: fix goroutine leak related to state snapshot generation (#28974) --------- Co-authored-by: Felix Lange <fjl@twurst.com> * ethereum, ethclient: add blob transaction fields in CallMsg (#28989) Co-authored-by: Felix Lange <fjl@twurst.com> * core/txpool/blobpool: rename variables in comments (#28981) Co-authored-by: Felix Lange <fjl@twurst.com> * cmd/devp2p: fix modulo in makeBlobTxs (#28970) * eth/catalyst,beacon/engine: implement GetClientVersionV1 (#28915) * tests: update execution spec tests + split statetest exec (#28993) * eth/catalyst: add getClientVersion to capabilities (#28994) * cmd/evm: fix typo in test script (#28995) * cmd/devp2p/internal/ethtest: some fixes for the eth test suite (#28996) Improving two things here: On hive, where we look at these tests, the Go code comment above the test is not visible. When there is a failure, it's not obvious what the test is actually expecting. I have converted the comments in to printed log messages to explain the test more. Second, I noticed that besu is failing some tests because it happens to request a header when we want it to send transactions. Trying the minimal fix here to serve the headers. Co-authored-by: lightclient <14004106+lightclient@users.noreply.github.com> * core/txpool/legacypool: remove a redundant heap.Init (#28910) Co-authored-by: Martin HS <martin@swende.se> Co-authored-by: Felix Lange <fjl@twurst.com> * core/txpool/blobpool: update the blob db with corruption handling (#29001) Updates billy to a more recent version which is more robust in the face of corrupt data (e.g. after a hard crash) * core: move genesis alloc types to core/types (#29003) We want to use these types in public user-facing APIs, so they shouldn't be in core. Co-authored-by: Felix Lange <fjl@twurst.com> * core/txpool, eth, miner: pre-filter dynamic fees during pending tx retrieval (#29005) * core/txpool, eth, miner: pre-filter dynamic fees during pending tx retrieval * miner: fix typo * core/txpool: handle init-error in blobpool without panicing --------- Co-authored-by: Martin Holst Swende <martin@swende.se> * ethstats: prevent panic if head block is not available (#29020) This pull request fixes a flaw in ethstats which can lead to node crash A panic could happens when the local blockchain is reorging which causes the original head block not to be reachable (since number->hash canonical mapping is deleted). In order to prevent the panic, the block nilness is now checked in ethstats. * core: using math.MaxUint64 instead of 0xffffffffffffffff (#29022) * core/txpool, miner: speed up blob pool pending retrievals (#29008) * core/txpool, miner: speed up blob pool pending retrievals * miner: fix test merge issue * eth: same same * core/txpool/blobpool: speed up blobtx creation in benchmark a bit * core/txpool/blobpool: fix linter --------- Co-authored-by: Martin Holst Swende <martin@swende.se> * core/vm, params: ensure order of forks, prevent overflow (#29023) This PR fixes an overflow which can could happen if inconsistent blockchain rules were configured. Additionally, it tries to prevent such inconsistencies from occurring by making sure that merge cannot be enabled unless previous fork(s) are also enabled. * core/txpool, eth, miner: retrieve plain and blob txs separately (#29026) * core/txpool, eth, miner: retrieve plain and blob txs separately * core/txpool: fix typo, no farming * miner: farm all the typos Co-authored-by: Martin HS <martin@swende.se> --------- Co-authored-by: Martin HS <martin@swende.se> * core/txpool: fix typo (#29031) * core,eth,internal: fix typo (#29024) * params: add cancun upgrade banner (#29042) params: add cancun banner Signed-off-by: tmelhao <tmelhao@gmail.com> Co-authored-by: tmelhao <tmelhao@gmail.com> * core/txpool: fix typo (#29036) * fix typos * address comments * internal/ethapi: fix defaults for blob fields (#29037) Co-authored-by: Martin HS <martin@swende.se> * params: release go-ethereum v1.13.13 stable * params: begin v1.13.14 release cycle * internal/ethapi: use overriden baseFee for gasPrice (#29051) eth_call and debug_traceCall allow users to override various block fields, among them base fee. However the overriden base fee was not considered for computing the effective gas price of that message, and instead base fee of the base block was used. This has been fixed in this commit. * internal/ethapi:fix zero rpc gas cap in eth_createAccessList (#28846) This PR enhances eth_createAccessList RPC call to support scenarios where the node is launched with an unlimited gas cap (--rpc.gascap 0). The eth_createAccessList RPC call returns failure if user doesn't explicitly set a gas limit. * eth/catalyst: fix wrong error message of payloadV2 after cancun (#29049) * eth/catalyst: the same error format Signed-off-by: tmelhao <tmelhao@gmail.com> * eth/catalyst: wrong error message for payloadV2 post-cancun Signed-off-by: tmelhao <tmelhao@gmail.com> * eth/catalyst: parentBeaconBlockRoot -> parentBlockBeaconRoot Signed-off-by: tmelhao <tmelhao@gmail.com> * apply commit review Signed-off-by: tmelhao <tmelhao@gmail.com> --------- Signed-off-by: tmelhao <tmelhao@gmail.com> Co-authored-by: tmelhao <tmelhao@gmail.com> * core/txpool: reject blob txs with blob fee cap below the minimum (#29081) * make blobpool reject blob transactions with fee below the minimum * core/txpool: some minot nitpick polishes and unified error formats * core/txpool: do less big.Int constructions with the min blob cap --------- Co-authored-by: Péter Szilágyi <peterke@gmail.com> * p2p, log, rpc: use errors.New to replace fmt.Errorf with no parameters (#29074) * eth/catalyst: enable some commented-out testcases (#29073) * internal/ethapi: pass blob hashes to gas estimation (#29085) * cmd/clef: add spaces in README.md table (#29077) Add space after links in so they are clickable in vscode. * eth/catalyst: remove variable in tx conversion loop (#29076) * core/txpool/blobpool: reduce default database cap for rollout (#29090) xcore/txpool/blobpool: reduce default database cap for rollout * core/txpool: no need to log loud rotate if no local txs (#29083) * core/txpool: no need to run rotate if no local txs Signed-off-by: jsvisa <delweng@gmail.com> * Revert "core/txpool: no need to run rotate if no local txs" This reverts commit 17fab173883168c586d57ca9c05dfcbd9e7831b4. Signed-off-by: jsvisa <delweng@gmail.com> * use Debug if todo is empty Signed-off-by: jsvisa <delweng@gmail.com> --------- Signed-off-by: jsvisa <delweng@gmail.com> * eth/tracers: Fix callTracer logs on onlyTopCall == true (#29068) * core/txpool: elevate the 'already reserved' error into a constant (#29095) declare the 'already reserved' error in errors.go * params: release Geth v1.13.14 * eth/protocols/snap: skip retrieval for completed storages (#29378) * eth/protocols/snap: skip retrieval for completed storages * eth/protocols/snap: address comments from peter * eth/protocols/snap: add comments * core/rawdb: add sanity-limit to header accessor (#29534) * eth/filters: enforce topic-limit early on filter criterias (#29535) This PR adds a limit of 1000 to the "inner" topics in a filter-criteria * core, eth/protocols/snap, trie: fix cause for snap-sync corruption, implement gentrie (#29313) This pull request defines a gentrie for snap sync purpose. The stackTrie is used to generate the merkle tree nodes upon receiving a state batch. Several additional options have been added into stackTrie to handle incomplete states (either missing states before or after). In this pull request, these options have been relocated from stackTrie to genTrie, which serves as a wrapper for stackTrie specifically for snap sync purposes. Further, the logic for managing incomplete state has been enhanced in this change. Originally, there are two cases handled: - boundary node filtering - internal (covered by extension node) node clearing This changes adds one more: - Clearing leftover nodes on the boundaries. This feature is necessary if there are leftover trie nodes in database, otherwise node inconsistency may break the state healing. * params: release Geth v 1.13.15 * copy new files from bsc@v1.4.6 * copy from bsc v1.4.6 * resolve interface missing method error for mock structs * apply finality to our consensus * add oasys consensus test: env/validators assemble * whether broadcast vote judging from peers's TD * fix lots of error to make work voting * increase vote DOS threadhold * fix lint error * modify go.mod according to BSC * vote attestaion stake weighted * add MaliciousVoteMonitor * remove bsc dependent comments/message * rename finalizer to fast finality * replace genesis contract by v1.6.0 * update genesis contract submodule (v1.6.0) * resolved several consensus issue * increment version to v1.6.0 * print error log: prepareWork and commit * print warn log in case of invalid vote * sort validators by owner for fast finality * apply validators sort changes to snapshot.go * disable deployments11 * refactor consensus * upgrade stake manager contract version * delete unused CeilDiv function * delete unused metrics.label file copyed from bsc * add comment to formHeader of finalize and seal case * add comment why disable fromHeader on Finalize * fix mainnet sync error: failed to verify header * fix getValidators marshal error by suppporting old contract interface * commit leak of previous one * fix verify header error by adding missing return * deal with unexpected value is presented to callGetHighStakesCommon * fix getHighStakes unpack error. replace wrong contract * sort by owner only fast finality enabled * Improved performance degradation due to change in json format of consensus snapshot * Improved EnvironmentValue parsing (#70) * Add note to BLSPublicKey's Marshaler * fix null pointer error after taking #69 * temporary set testnet hardfork for private testnet * increase private testnet hardork block * bring private hardfork time closer * fix feedback from @ironbeer part1 * vot validator point to parent block(=target block) * Add contract deploy test * Update consensus/oasys/snapshot.go Co-authored-by: ironbeer <7997273+ironbeer@users.noreply.github.com> * fix feedback from ironbeer part2 * Added `Equal` method to EnvironmentValue (#71) * Imported diffs of blockchain.go and headerchain.go from bsc@v1.4.6 (#74) * Imported diffs of blockchain.go and headerchain.go from bsc@v1.4.6 * Imported fast finality reorganization from bsc@v1.4.6 (#75) * Imported fast finality reorganization from bsc@v1.4.6 * Fix errors in test code * elaborate the timeing update finalized and justified gauge (#77) --------- Co-authored-by: tak <re795h@gmail.com> * Fix panic when BLS key is nothing & support multiple keys (#81) * Imported eth.handler from bsc@v1.4.6 (#78) * Imported stop process of eth.handler from bsc@v1.4.6 * Imported `chainFinalizedHeightFn` of fetcher.BlockFetcher from bsc@v1.4.6 * remove stop chan from eth/handler (#82) --------- Co-authored-by: tak <re795h@gmail.com> * fix feadback from ironbeer part3 * Fix reorg when justification chain is split (#85) * update loas contract & reset testnet hardfork schedule * fix compile error (#80) * support eth67 * secured go.mod * fix compile error * upgrade wealdtech/go-eth2-types/v2 from v2.5.2 to v2.8.1, to avoid bnb forked fastssz * downgrade github.com/wealdtech/go-eth2-types to v2.6.0, to kept github.com/ferranbt/fastssz version as v0.1.2 * rever back github.com/herumi/bls-eth-go-binary original version * Integrate BSC cancun support (#84) * support eth67 * secured go.mod * fix compile error * upgrade wealdtech/go-eth2-types/v2 from v2.5.2 to v2.8.1, to avoid bnb forked fastssz * downgrade github.com/wealdtech/go-eth2-types to v2.6.0, to kept github.com/ferranbt/fastssz version as v0.1.2 * rever back github.com/herumi/bls-eth-go-binary original version * integrate bsc cancun support * import bsc PR #2428 * import bsc PR #2525 * import bsc PR #2350 * import bsc PR #2311 * import bsc PR #2337 * Updated with `gencodec -dir eth/ethconfig/ -type Config -formats toml -out eth/ethconfig/gen_config.go` (#94) * Import eth/handler.go from bsc@v1.4.15 (#93) * Update core/blockchain.go Co-authored-by: ironbeer <7997273+ironbeer@users.noreply.github.com> * Update core/chain_makers.go Co-authored-by: ironbeer <7997273+ironbeer@users.noreply.github.com> * respond review by ironbeer part1 * Restore changes from 4e4fa3e (#95) * Update params/config.go Co-authored-by: ironbeer <7997273+ironbeer@users.noreply.github.com> * Import miner/worker.go from bsc@v1.4.15 (2) (#99) * Import miner/worker.go from bsc@v1.4.15 (3) (#100) * Update consensus/oasys/oasys.go Co-authored-by: ironbeer <7997273+ironbeer@users.noreply.github.com> --------- Co-authored-by: ironbeer <7997273+ironbeer@users.noreply.github.com> * もろもろの調整を加えた最終系 (#86) * support eth67 * secured go.mod * fix compile error * upgrade wealdtech/go-eth2-types/v2 from v2.5.2 to v2.8.1, to avoid bnb forked fastssz * downgrade github.com/wealdtech/go-eth2-types to v2.6.0, to kept github.com/ferranbt/fastssz version as v0.1.2 * rever back github.com/herumi/bls-eth-go-binary original version * integrate bsc cancun support * import bsc PR #2428 * import bsc PR #2525 * import bsc PR #2350 * import bsc PR #2311 * import bsc PR #2337 * organize ParentBeaconRoot handling * unsupport eth67 * fix linter error * fix `unexpected withdrawal hash value in oasys` * set blob index during commit it * add fake beacon api * fix blob freeze bugs * Updated with `gencodec -dir eth/ethconfig/ -type Config -formats toml -out eth/ethconfig/gen_config.go` (#94) * Import eth/handler.go from bsc@v1.4.15 (#93) * Update core/blockchain.go Co-authored-by: ironbeer <7997273+ironbeer@users.noreply.github.com> * Update core/chain_makers.go Co-authored-by: ironbeer <7997273+ironbeer@users.noreply.github.com> * respond review by ironbeer part1 * Restore changes from 4e4fa3e (#95) * Update params/config.go Co-authored-by: ironbeer <7997273+ironbeer@users.noreply.github.com> * fastfinality: incorporate bsc changes ##2589 * fastfinality: incorporate bsc PR #2568 * fix consensus making failure caused by integration of bsc pr #2589 * Import miner/worker.go from bsc@v1.4.15 (2) (#99) * Import miner/worker.go from bsc@v1.4.15 (3) (#100) * Dedup of BaseFee field after cancun (#102) * Import blob fee API from geth@v1.14.11 (#103) * Fixed fakebeacon (#104) * Change index field to string type * Modified block estimation for Oasys * respond feedback from ironbeer --------- Co-authored-by: ironbeer <7997273+ironbeer@users.noreply.github.com> * abjust blobs reserve periods (#106) * Feat/evm access control (#105) * support eth67 * secured go.mod * fix compile error * upgrade wealdtech/go-eth2-types/v2 from v2.5.2 to v2.8.1, to avoid bnb forked fastssz * downgrade github.com/wealdtech/go-eth2-types to v2.6.0, to kept github.com/ferranbt/fastssz version as v0.1.2 * rever back github.com/herumi/bls-eth-go-binary original version * integrate bsc cancun support * import bsc PR #2428 * import bsc PR #2525 * import bsc PR #2350 * import bsc PR #2311 * import bsc PR #2337 * organize ParentBeaconRoot handling * unsupport eth67 * fix linter error * fix `unexpected withdrawal hash value in oasys` * set blob index during commit it * add fake beacon api * fix blob freeze bugs * Updated with `gencodec -dir eth/ethconfig/ -type Config -formats toml -out eth/ethconfig/gen_config.go` (#94) * Import eth/handler.go from bsc@v1.4.15 (#93) * Update core/blockchain.go Co-authored-by: ironbeer <7997273+ironbeer@users.noreply.github.com> * Update core/chain_makers.go Co-authored-by: ironbeer <7997273+ironbeer@users.noreply.github.com> * respond review by ironbeer part1 * Restore changes from 4e4fa3e (#95) * Update params/config.go Co-authored-by: ironbeer <7997273+ironbeer@users.noreply.github.com> * fastfinality: incorporate bsc changes ##2589 * fastfinality: incorporate bsc PR #2568 * fix consensus making failure caused by integration of bsc pr #2589 * Import miner/worker.go from bsc@v1.4.15 (2) (#99) * Import miner/worker.go from bsc@v1.4.15 (3) (#100) * Dedup of BaseFee field after cancun (#102) * Import blob fee API from geth@v1.14.11 (#103) * Fixed fakebeacon (#104) * Change index field to string type * Modified block estimation for Oasys * add evm access controler experlimentaly * respond feedback from ironbeer * brash up evm access controller * add missing key mapping to evm control contract * remove Oasys.TxVerify * add deployment13 testcase * resolve evm access denied tx persisted in txpool bug (#108) * Add from/to validation to eth_sendRawTransaction (#107) * Add validation to SendRawTransaction * Rename EVMAccessControl to TransactionFilter and move validation to txpool * Revert "Rename EVMAccessControl to TransactionFilter and move validation to txpool" This reverts commit 4dac3f8. * Fix package error * Improved error message --------- Co-authored-by: ironbeer <7997273+ironbeer@users.noreply.github.com> * temporaly force validators to enable vote to activate fast finality (#109) * temporaly force validators to enable vote to activate fast finality * remove voting as keyword to avoid confusion --------- Signed-off-by: tmelhao <tmelhao@gmail.com> Signed-off-by: jsvisa <delweng@gmail.com> Co-authored-by: Martin Holst Swende <martin@swende.se> Co-authored-by: cygaar <97691933+cygaar@users.noreply.github.com> Co-authored-by: Mario Vega <marioevz@gmail.com> Co-authored-by: Taeguk Kwon <xornrbboy@gmail.com> Co-authored-by: Felix Lange <fjl@twurst.com> Co-authored-by: ddl <ddl196526@163.com> Co-authored-by: Darioush Jalali <darioush.jalali@avalabs.org> Co-authored-by: Marius Kjærstad <sandakersmann@users.noreply.github.com> Co-authored-by: Rossen Krastev <rosen4obg@gmail.com> Co-authored-by: ucwong <ucwong@126.com> Co-authored-by: jwasinger <j-wasinger@hotmail.com> Co-authored-by: vuittont60 <81072379+vuittont60@users.noreply.github.com> Co-authored-by: Marius van der Wijden <m.vanderwijden@live.de> Co-authored-by: rjl493456442 <garyrong0905@gmail.com> Co-authored-by: Péter Szilágyi <peterke@gmail.com> Co-authored-by: drstevenbrule <110744990+drstevenbrule@users.noreply.github.com> Co-authored-by: lightclient <14004106+lightclient@users.noreply.github.com> Co-authored-by: HAOYUatHZ <37070449+HAOYUatHZ@users.noreply.github.com> Co-authored-by: Sina Mahmoodi <1591639+s1na@users.noreply.github.com> Co-authored-by: hyunchel <3271191+hyunchel@users.noreply.github.com> Co-authored-by: 牛晓婕 <30611384+niuxiaojie81@users.noreply.github.com> Co-authored-by: Alfie John <alfiedotwtf@users.noreply.github.com> Co-authored-by: alex <152680487+bodhi-crypo@users.noreply.github.com> Co-authored-by: Paul Lange <palango@users.noreply.github.com> Co-authored-by: Thabokani <149070269+Thabokani@users.noreply.github.com> Co-authored-by: colin <102356659+colinlyguo@users.noreply.github.com> Co-authored-by: Guillaume Ballet <3272758+gballet@users.noreply.github.com> Co-authored-by: trocher <trooocher@proton.me> Co-authored-by: protolambda <proto@protolambda.com> Co-authored-by: KeienWang <42377006+keienWang@users.noreply.github.com> Co-authored-by: zoereco <158379334+zoereco@users.noreply.github.com> Co-authored-by: Chris Ziogas <ziogaschr@gmail.com> Co-authored-by: Dimitris Apostolou <dimitris.apostolou@icloud.com> Co-authored-by: Halimao <1065621723@qq.com> Co-authored-by: lmittmann <3458786+lmittmann@users.noreply.github.com> Co-authored-by: Peter Straus <153843855+krauspt@users.noreply.github.com> Co-authored-by: maskpp <maskpp266@gmail.com> Co-authored-by: Ng Wei Han <47109095+weiihann@users.noreply.github.com> Co-authored-by: Lindlof <mikael@lindlof.io> Co-authored-by: bk <5810624+bkellerman@users.noreply.github.com> Co-authored-by: cui <523516579@qq.com> Co-authored-by: buddho <galaxystroller@gmail.com> Co-authored-by: Haotian <51777534+tmelhao@users.noreply.github.com> Co-authored-by: tmelhao <tmelhao@gmail.com> Co-authored-by: ArtificialPB <matej.berger@hotmail.com> Co-authored-by: Roberto Bayardo <roberto.bayardo@coinbase.com> Co-authored-by: Qt <golang.chen@gmail.com> Co-authored-by: Justin Dhillon <justin.singh.dhillon@gmail.com> Co-authored-by: Delweng <delweng@gmail.com> Co-authored-by: Andrei Silviu Dragnea <andreisilviudragnea@gmail.com> Co-authored-by: ironbeer <7997273+ironbeer@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.