Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: flat config compatible #30

Merged
merged 10 commits into from
Sep 10, 2024
Merged

feat: flat config compatible #30

merged 10 commits into from
Sep 10, 2024

Conversation

yairkukielka
Copy link
Contributor

@yairkukielka yairkukielka commented Sep 2, 2024

Ticket https://oat-sa.atlassian.net/browse/FUN-1899

BREAKING CHANGE: split jest and svelte configs

The first commit of this PR has a BREAKING CHANGE: tag for conventional commits to bump the major version:
Screenshot 2024-09-02 at 09 32 20

This PR has 2 main changes for frontend configs:

  • Split svelte+jest rules apart so we can also use svelte with vitest rules. We now have the svelte, jest and svelte configs available separately for better composability.

  • Add the new svelte flat config necessary for eslint 9. Also, deprecate the current frontend configs (adding legacy to their names).

To facilitate testing this PR I'm providing below a couple of branches in different projects where you can test the new and old configs working. You shouln't appreciate changes in the legacy config, and there might be slight changes in the new flat configs, but you probably won't notice them. The idea is for you to check out these branches and run eslint locally

These branches use an alpha version of @oat-sa/eslint-config-tao v4 so they are easier to test:
Vite app template: https://github.com/oat-sa/vite-app-template/pull/6
Control center: https://github.com/oat-sa/tao-control-center/pull/127

There are small changes in other configs. Please check the changelog

flat/svelte.mjs Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
svelte-jest-legacy.js Outdated Show resolved Hide resolved
@jsconan jsconan self-requested a review September 4, 2024 08:53
Copy link
Contributor

@jsconan jsconan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks great!
The remaining points need to be addressed as discussed, but I already approve as the proposal is already good.

Good job!

Copy link
Contributor

@jsconan jsconan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait, the target branch should be develop, not master

@oatymart oatymart changed the base branch from master to develop September 10, 2024 13:15
@oatymart oatymart self-assigned this Sep 10, 2024
@oatymart oatymart merged commit 57d5d32 into develop Sep 10, 2024
@oatymart oatymart deleted the feat/FUN-1899-split-configs branch September 10, 2024 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants