-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: flat config compatible #30
Conversation
BREAKING CHANGE: split jest and svelte configs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks great!
The remaining points need to be addressed as discussed, but I already approve as the proposal is already good.
Good job!
Fix/FUN-1899/turn off annoying rules
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wait, the target branch should be develop
, not master
Ticket https://oat-sa.atlassian.net/browse/FUN-1899
BREAKING CHANGE: split jest and svelte configs
The first commit of this PR has a BREAKING CHANGE: tag for conventional commits to bump the major version:
This PR has 2 main changes for frontend configs:
Split svelte+jest rules apart so we can also use svelte with vitest rules. We now have the svelte, jest and svelte configs available separately for better composability.
Add the new svelte flat config necessary for eslint 9. Also, deprecate the current frontend configs (adding
legacy
to their names).To facilitate testing this PR I'm providing below a couple of branches in different projects where you can test the new and old configs working. You shouln't appreciate changes in the legacy config, and there might be slight changes in the new flat configs, but you probably won't notice them. The idea is for you to check out these branches and run eslint locally
These branches use an alpha version of
@oat-sa/eslint-config-tao v4
so they are easier to test:Vite app template: https://github.com/oat-sa/vite-app-template/pull/6
Control center: https://github.com/oat-sa/tao-control-center/pull/127
There are small changes in other configs. Please check the changelog